Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 442853003: libwebp: mips build fixes (Closed)

Created:
6 years, 4 months ago by jzern
Modified:
6 years, 4 months ago
Reviewers:
urvang (Google)
CC:
chromium-reviews, jzern, skal, vikasa, clank-webview_google.com
Project:
chromium
Visibility:
Public.

Description

libwebp: mips build fixes dsp: detect mips64 & disable mips32 code enc_mips32: workaround gcc-4.9 bug BUG=374343 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287728

Patch Set 1 #

Total comments: 2

Patch Set 2 : drop internal bug reference #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M third_party/libwebp/README.chromium View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/libwebp/dsp/cpu.c View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libwebp/dsp/dsp.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libwebp/dsp/enc_mips32.c View 4 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jzern
6 years, 4 months ago (2014-08-05 19:52:18 UTC) #1
urvang (Google)
https://codereview.chromium.org/442853003/diff/1/third_party/libwebp/README.chromium File third_party/libwebp/README.chromium (right): https://codereview.chromium.org/442853003/diff/1/third_party/libwebp/README.chromium#newcode23 third_party/libwebp/README.chromium:23: * b/16736930: fcf7687 enc_mips32: workaround gcc-4.9 bug Remove the ...
6 years, 4 months ago (2014-08-05 23:59:10 UTC) #2
jzern
https://codereview.chromium.org/442853003/diff/1/third_party/libwebp/README.chromium File third_party/libwebp/README.chromium (right): https://codereview.chromium.org/442853003/diff/1/third_party/libwebp/README.chromium#newcode23 third_party/libwebp/README.chromium:23: * b/16736930: fcf7687 enc_mips32: workaround gcc-4.9 bug On 2014/08/05 ...
6 years, 4 months ago (2014-08-06 00:15:57 UTC) #3
urvang (Google)
lgtm
6 years, 4 months ago (2014-08-06 00:21:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jzern@chromium.org/442853003/20001
6 years, 4 months ago (2014-08-06 00:23:14 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 07:28:05 UTC) #6
Message was sent while issue was closed.
Change committed as 287728

Powered by Google App Engine
This is Rietveld 408576698