Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 442853002: Fix metrics-reporting-enabled date expectations post metrics IDs reset. (Closed)

Created:
6 years, 4 months ago by gab
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Fix metrics-reporting-enabled date expectations post metrics IDs reset. BUG=400561 TEST=Add a Sleep(1000) before this section of the test: fails before this CL, succeeds now. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287632

Patch Set 1 #

Patch Set 2 : better checks for other Time::Now() tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M components/metrics/metrics_state_manager_unittest.cc View 1 4 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
gab
Alexei PTAL. Thanks! Gab
6 years, 4 months ago (2014-08-05 18:33:46 UTC) #1
Alexei Svitkine (slow)
LGTM, thanks for fixing!
6 years, 4 months ago (2014-08-05 18:56:44 UTC) #2
gab
The CQ bit was checked by gab@chromium.org
6 years, 4 months ago (2014-08-05 18:58:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/442853002/20001
6 years, 4 months ago (2014-08-05 19:00:13 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 23:03:36 UTC) #5
Message was sent while issue was closed.
Change committed as 287632

Powered by Google App Engine
This is Rietveld 408576698