Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 442833002: Disallow Easy Unlock in secondary user profiles. (Closed)

Created:
6 years, 4 months ago by Tim Song
Modified:
6 years, 4 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Disallow Easy Unlock in secondary user profiles. BUG=398946 TEST=manual and browser test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288004

Patch Set 1 #

Patch Set 2 : added test #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : remove static #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -5 lines) Patch
M chrome/browser/chromeos/profiles/profile_helper.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/profiles/profile_helper.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_browsertest_chromeos.cc View 1 2 3 4 chunks +68 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Tim Song
6 years, 4 months ago (2014-08-05 18:13:09 UTC) #1
xiyuan
LGTM EasyUnlockServiceTest might be unhappy with the IsPrimaryProfile check though.
6 years, 4 months ago (2014-08-05 18:29:39 UTC) #2
Tim Song
I wrote a test for multiprofiles. Please take another look.
6 years, 4 months ago (2014-08-06 21:45:46 UTC) #3
xiyuan
LGTM++ https://codereview.chromium.org/442833002/diff/40001/chrome/browser/signin/easy_unlock_service_browsertest_chromeos.cc File chrome/browser/signin/easy_unlock_service_browsertest_chromeos.cc (right): https://codereview.chromium.org/442833002/diff/40001/chrome/browser/signin/easy_unlock_service_browsertest_chromeos.cc#newcode40 chrome/browser/signin/easy_unlock_service_browsertest_chromeos.cc:40: static const char kTestUser2[] = "secondary.user@example.com"; nit: "static" ...
6 years, 4 months ago (2014-08-06 21:50:33 UTC) #4
Tim Song
https://codereview.chromium.org/442833002/diff/40001/chrome/browser/signin/easy_unlock_service_browsertest_chromeos.cc File chrome/browser/signin/easy_unlock_service_browsertest_chromeos.cc (right): https://codereview.chromium.org/442833002/diff/40001/chrome/browser/signin/easy_unlock_service_browsertest_chromeos.cc#newcode40 chrome/browser/signin/easy_unlock_service_browsertest_chromeos.cc:40: static const char kTestUser2[] = "secondary.user@example.com"; On 2014/08/06 21:50:33, ...
6 years, 4 months ago (2014-08-06 21:55:56 UTC) #5
Tim Song
The CQ bit was checked by tengs@chromium.org
6 years, 4 months ago (2014-08-07 00:43:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tengs@chromium.org/442833002/60001
6 years, 4 months ago (2014-08-07 00:46:02 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 07:58:03 UTC) #8
Message was sent while issue was closed. 
Change committed as 288004

Powered by Google App Engine
This is Rietveld 408576698