components/cronet/android/url_request_peer.cc - Issue 442803002: Remove explicit JNI references by adding UrlRequest.readFromUploadChannel callback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/url_request_peer.cc

Issue 442803002: Remove explicit JNI references by adding UrlRequest.readFromUploadChannel callback. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address Matt's comments. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/org_chromium_net_UrlRequest.cc ('K') | « components/cronet/android/url_request_peer.h ('k') | components/cronet/android/wrapped_channel_upload_element_reader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/url_request_peer.cc

diff --git a/components/cronet/android/url_request_peer.cc b/components/cronet/android/url_request_peer.cc

index 37385cfab871deb427539d1783b9cac585b6eaab..e6f16f2ccf355427a6317a99bf4e2898118cfb9e 100644

--- a/components/cronet/android/url_request_peer.cc

+++ b/components/cronet/android/url_request_peer.cc

@@ -51,10 +51,9 @@ void URLRequestPeer::SetUploadContent(const char* bytes, int bytes_len) {

reader.Pass(), 0));

}

-void URLRequestPeer::SetUploadChannel(

- JNIEnv* env, jobject channel, int64 content_length) {

+void URLRequestPeer::SetUploadChannel(JNIEnv* env, int64 content_length) {

scoped_ptr<net::UploadElementReader> reader(

- new WrappedChannelElementReader(env, channel, content_length));

+ new WrappedChannelElementReader(delegate_, content_length));

upload_data_stream_.reset(net::UploadDataStream::CreateWithReader(

reader.Pass(), 0));

}