src/ic.cc - Issue 442763002: Load constants from the DescriptorArray

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic.cc

Issue 442763002: Load constants from the DescriptorArray (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic.cc

diff --git a/src/ic.cc b/src/ic.cc

index 846d361c089a593398aadf32c10b818737f56fa6..484b572093ce7d46067b26b80829c3386130987a 100644

--- a/src/ic.cc

+++ b/src/ic.cc

@@ -1069,8 +1069,11 @@ Handle<Code> LoadIC::CompileHandler(LookupIterator* lookup,

// -------------- Constant properties --------------

DCHECK(lookup->property_details().type() == CONSTANT);

- Handle<Object> constant = lookup->GetDataValue();

- return compiler.CompileLoadConstant(name, constant);

+ if (receiver_is_holder) {

+ LoadConstantStub stub(isolate(), lookup->GetConstantIndex());

+ return stub.GetCode();

+ }

+ return compiler.CompileLoadConstant(name, lookup->GetConstantIndex());

}