Chromium Code Reviews

Issue 442763002: Load constants from the DescriptorArray (Closed)

Created:
6 years, 4 months ago by Toon Verwaest
Modified:
6 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Load constants from the DescriptorArray BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22899

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comment #

Patch Set 3 : Also removed from arm64 #

Unified diffs Side-by-side diffs Stats (+95 lines, -114 lines)
M src/arm/stub-cache-arm.cc View 1 chunk +0 lines, -8 lines 0 comments
M src/arm64/stub-cache-arm64.cc View 1 chunk +0 lines, -15 lines 0 comments
M src/code-stubs.h View 5 chunks +24 lines, -8 lines 0 comments
M src/code-stubs.cc View 2 chunks +13 lines, -24 lines 0 comments
M src/code-stubs-hydrogen.cc View 1 chunk +18 lines, -1 line 0 comments
M src/ia32/stub-cache-ia32.cc View 1 chunk +0 lines, -8 lines 0 comments
M src/ic.cc View 1 chunk +6 lines, -3 lines 0 comments
M src/lookup.h View 1 chunk +1 line, -0 lines 0 comments
M src/lookup.cc View 1 chunk +11 lines, -1 line 0 comments
M src/mips/stub-cache-mips.cc View 1 chunk +0 lines, -8 lines 0 comments
M src/mips64/stub-cache-mips64.cc View 1 chunk +0 lines, -8 lines 0 comments
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments
M src/objects-inl.h View 1 chunk +5 lines, -0 lines 0 comments
M src/stub-cache.h View 3 chunks +2 lines, -6 lines 0 comments
M src/stub-cache.cc View 2 chunks +14 lines, -8 lines 0 comments
M src/x64/stub-cache-x64.cc View 1 chunk +0 lines, -8 lines 0 comments
M src/x87/stub-cache-x87.cc View 1 chunk +0 lines, -8 lines 0 comments

Messages

Total messages: 4 (0 generated)
Toon Verwaest
PTAL
6 years, 4 months ago (2014-08-05 13:31:30 UTC) #1
Jakob Kummerow
LGTM with nit (applies to all platforms). https://codereview.chromium.org/442763002/diff/1/src/ia32/stub-cache-ia32.cc File src/ia32/stub-cache-ia32.cc (right): https://codereview.chromium.org/442763002/diff/1/src/ia32/stub-cache-ia32.cc#newcode823 src/ia32/stub-cache-ia32.cc:823: if (!reg.is(receiver())) ...
6 years, 4 months ago (2014-08-05 13:50:58 UTC) #2
Toon Verwaest
Addressed comment. Moved the methods out of the platform specific files.
6 years, 4 months ago (2014-08-05 14:02:40 UTC) #3
Toon Verwaest
6 years, 4 months ago (2014-08-06 08:02:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as 22899 (presubmit successful).

Powered by Google App Engine