runtime/lib/string_patch.dart - Issue 442693002: Special case substring(0, length) to return itself.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/string_patch.dart

Issue 442693002: Special case substring(0, length) to return itself. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/string_patch.dart

diff --git a/runtime/lib/string_patch.dart b/runtime/lib/string_patch.dart

index ec793067394b7ce24877fd859874b7e07b6a02df..685b704a7568588bbc9871e9ec01ee35583d9019 100644

--- a/runtime/lib/string_patch.dart

+++ b/runtime/lib/string_patch.dart

@@ -247,6 +247,9 @@ class _StringBase {

if (startIndex == endIndex) {

return "";

}

+ if (startIndex == 0 && endIndex == this.length) {

Anders Johnsen 2014/08/05 08:59:25 Put (..) around endIndex == this.length.

Lasse Reichstein Nielsen 2014/08/05 09:26:56 I guess that's the local style.

+ return this;

+ }

if ((startIndex + 1) == endIndex) {

return this[startIndex];

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »