Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 442643002: Allow MediaStream constraints to specify higher than 30 FPS tab capture. (Closed)

Created:
6 years, 4 months ago by miu
Modified:
6 years, 4 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Allow MediaStream constraints to specify higher than 30 FPS tab capture. This will allow true 720p/60fps tab/desktop capture, if configured through the constraints (and the system hardware performance supports it). In addition, this will enable tab capture perf tests to run at higher frame rates so that more-subtle regressions are caught. A new hard upper-bound of 120 FPS is enforced with this change. BUG=400631 TBR=yzshen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287642

Patch Set 1 #

Patch Set 2 : Fix compile whoops. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -16 lines) Patch
M content/renderer/media/media_stream_video_capturer_source.h View 2 chunks +6 lines, -3 lines 0 comments Download
M content/renderer/media/media_stream_video_capturer_source.cc View 1 3 chunks +16 lines, -10 lines 0 comments Download
M content/renderer/media/media_stream_video_source.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/media_stream_video_source.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M content/renderer/media/mock_media_stream_video_source.h View 3 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/media/mock_media_stream_video_source.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/media/webrtc/media_stream_remote_video_source.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/webrtc/media_stream_remote_video_source.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/webrtc/video_destination_handler.h View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/video_destination_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/pepper/pepper_media_stream_video_track_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/pepper/pepper_media_stream_video_track_host.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
miu
tommi: PTAL. yzshen: Need OWNERS stamp for content/renderer/pepper/pepper_media_stream_video_track_host.*
6 years, 4 months ago (2014-08-05 04:45:29 UTC) #1
tommi (sloooow) - chröme
lgtm
6 years, 4 months ago (2014-08-05 08:49:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/442643002/20001
6 years, 4 months ago (2014-08-05 08:50:43 UTC) #3
tommi (sloooow) - chröme
The CQ bit was unchecked by tommi@chromium.org
6 years, 4 months ago (2014-08-05 09:15:59 UTC) #4
tommi (sloooow) - chröme
On 2014/08/05 08:50:43, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 4 months ago (2014-08-05 09:16:31 UTC) #5
miu
On 2014/08/05 09:16:31, tommi wrote: > On 2014/08/05 08:50:43, I haz the power (commit-bot) wrote: ...
6 years, 4 months ago (2014-08-05 19:05:10 UTC) #6
miu
The CQ bit was checked by miu@chromium.org
6 years, 4 months ago (2014-08-05 19:05:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/442643002/20001
6 years, 4 months ago (2014-08-05 19:07:44 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-05 20:56:38 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 22:00:21 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/1366)
6 years, 4 months ago (2014-08-05 22:00:22 UTC) #11
miu
The CQ bit was checked by miu@chromium.org
6 years, 4 months ago (2014-08-05 22:13:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/442643002/20001
6 years, 4 months ago (2014-08-05 22:14:10 UTC) #13
commit-bot: I haz the power
Change committed as 287642
6 years, 4 months ago (2014-08-05 23:35:19 UTC) #14
yzshen1
6 years, 4 months ago (2014-08-06 16:41:36 UTC) #15
Message was sent while issue was closed.
LGTM for .*pepper.*

Sorry I didn't notice this CL earlier.

Powered by Google App Engine
This is Rietveld 408576698