Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 442603006: Hide fullscreen button when fullscreen not supported. (Closed)

Created:
6 years, 4 months ago by Ignacio Solla
Modified:
6 years, 4 months ago
Reviewers:
philipj_slow, dglazkov
CC:
blink-reviews, blink-reviews-html_chromium.org, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, nessy, vcarbune.chromium, benm (inactive)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@fullscreenSpecChange
Project:
blink
Visibility:
Public.

Description

Hide fullscreen button when fullscreen not supported. BUG=400333 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179633

Patch Set 1 #

Patch Set 2 : nits #

Total comments: 4

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -7 lines) Patch
M LayoutTests/media/video-controls-fullscreen.js View 1 2 chunks +25 lines, -5 lines 0 comments Download
A + LayoutTests/media/video-controls-fullscreen-not-supported.html View 1 chunk +4 lines, -1 line 0 comments Download
M Source/core/html/shadow/MediaControls.cpp View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Ignacio Solla
6 years, 4 months ago (2014-08-05 13:36:11 UTC) #1
philipj_slow
LGTM with optional nits. https://codereview.chromium.org/442603006/diff/20001/LayoutTests/media/video-controls-fullscreen.js File LayoutTests/media/video-controls-fullscreen.js (right): https://codereview.chromium.org/442603006/diff/20001/LayoutTests/media/video-controls-fullscreen.js#newcode52 LayoutTests/media/video-controls-fullscreen.js:52: window.addEventListener("load", t.step_func(function() Since there's just ...
6 years, 4 months ago (2014-08-05 18:45:25 UTC) #2
Ignacio Solla
Thanks for the quick review! https://codereview.chromium.org/442603006/diff/20001/LayoutTests/media/video-controls-fullscreen.js File LayoutTests/media/video-controls-fullscreen.js (right): https://codereview.chromium.org/442603006/diff/20001/LayoutTests/media/video-controls-fullscreen.js#newcode52 LayoutTests/media/video-controls-fullscreen.js:52: window.addEventListener("load", t.step_func(function() On 2014/08/05 ...
6 years, 4 months ago (2014-08-06 10:41:56 UTC) #3
Ignacio Solla
The CQ bit was checked by igsolla@chromium.org
6 years, 4 months ago (2014-08-06 10:42:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/igsolla@chromium.org/442603006/40001
6 years, 4 months ago (2014-08-06 10:42:40 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-06 13:15:13 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-06 13:47:53 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/20057)
6 years, 4 months ago (2014-08-06 13:47:54 UTC) #8
Ignacio Solla
The CQ bit was checked by igsolla@chromium.org
6 years, 4 months ago (2014-08-06 14:18:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/igsolla@chromium.org/442603006/40001
6 years, 4 months ago (2014-08-06 14:19:22 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-06 15:41:06 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 17:11:02 UTC) #12
Message was sent while issue was closed.
Change committed as 179633

Powered by Google App Engine
This is Rietveld 408576698