Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: chrome/browser/resources/options/chromeos/keyboard_overlay.js

Issue 442583002: Change document.title used for keyboard overlay (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options', function() { 5 cr.define('options', function() {
6 6
7 /** 7 /**
8 * Auto-repeat delays (in ms) for the corresponding slider values, from 8 * Auto-repeat delays (in ms) for the corresponding slider values, from
9 * long to short. The values were chosen to provide a large range while giving 9 * long to short. The values were chosen to provide a large range while giving
10 * several options near the defaults. 10 * several options near the defaults.
(...skipping 12 matching lines...) Expand all
23 */ 23 */
24 var AUTO_REPEAT_INTERVALS = 24 var AUTO_REPEAT_INTERVALS =
25 [2000, 1000, 500, 300, 200, 100, 50, 30, 20]; 25 [2000, 1000, 500, 300, 200, 100, 50, 30, 20];
26 26
27 /** 27 /**
28 * Encapsulated handling of the keyboard overlay. 28 * Encapsulated handling of the keyboard overlay.
29 * @constructor 29 * @constructor
30 */ 30 */
31 function KeyboardOverlay() { 31 function KeyboardOverlay() {
32 options.SettingsDialog.call(this, 'keyboard-overlay', 32 options.SettingsDialog.call(this, 'keyboard-overlay',
33 loadTimeData.getString('keyboardOverlayTitle'), 33 loadTimeData.getString('keyboardOverlayTabTitle'),
stevenjb 2014/08/05 21:23:57 So, RegisterTitle generates the 'keyboardOverlayTa
michaelpg 2014/08/05 21:41:05 Yep, I noticed other overlays tend to use it for t
34 'keyboard-overlay', 34 'keyboard-overlay',
35 $('keyboard-confirm'), $('keyboard-cancel')); 35 $('keyboard-confirm'), $('keyboard-cancel'));
36 } 36 }
37 37
38 cr.addSingletonGetter(KeyboardOverlay); 38 cr.addSingletonGetter(KeyboardOverlay);
39 39
40 KeyboardOverlay.prototype = { 40 KeyboardOverlay.prototype = {
41 __proto__: options.SettingsDialog.prototype, 41 __proto__: options.SettingsDialog.prototype,
42 42
43 /** @override */ 43 /** @override */
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 var instance = KeyboardOverlay.getInstance(); 168 var instance = KeyboardOverlay.getInstance();
169 return instance[name + '_'].apply(instance, arguments); 169 return instance[name + '_'].apply(instance, arguments);
170 }; 170 };
171 }); 171 });
172 172
173 // Export 173 // Export
174 return { 174 return {
175 KeyboardOverlay: KeyboardOverlay 175 KeyboardOverlay: KeyboardOverlay
176 }; 176 };
177 }); 177 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698