Change document.title used for keyboard overlay

Change document.title used for keyboard overlay

The window title should be "Settings - Keyboard settings", but that
prefix is missing.

This doesn't change the title display within the overlay itself
("Keyboard settings").

R=stevenjb@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287702

[stevenjb, 2014-08-05 21:23:57]

https://codereview.chromium.org/442583002/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/chromeos/keyboard_overlay.js (right):

https://codereview.chromium.org/442583002/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/chromeos/keyboard_overlay.js:33:
loadTimeData.getString('keyboardOverlayTabTitle'),
So, RegisterTitle generates the 'keyboardOverlayTabTitle' string? Assuming so,
lgtm.

[michaelpg, 2014-08-05 21:40:51]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2014-08-05 21:41:05]

Thanks

https://codereview.chromium.org/442583002/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/chromeos/keyboard_overlay.js (right):

https://codereview.chromium.org/442583002/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/chromeos/keyboard_overlay.js:33:
loadTimeData.getString('keyboardOverlayTabTitle'),
On 2014/08/05 21:23:57, stevenjb wrote:
> So, RegisterTitle generates the 'keyboardOverlayTabTitle' string? Assuming so,
> lgtm.

Yep, I noticed other overlays tend to use it for this. It registers
'keyboardOverlay' ('Keyboard settings') and also registers
'keyboardOverlayTabTitle' which will be 'Settings - Keyboard settings'.

[commit-bot: I haz the power, 2014-08-05 21:42:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/michaelpg@chromium.org/442583002/1

[commit-bot: I haz the power, 2014-08-06 03:02:27]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-06 06:16:59]

Change committed as 287702