LayoutTests/fast/css/area-computedStyle.html - Issue 442563002: Fix getComputedStyle() for area element

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css/area-computedStyle.html

Issue 442563002: Fix getComputedStyle() for area element (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix code style Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/accessibility/image-map1.html ('K') | « LayoutTests/accessibility/image-map2-expected.txt ('k') | LayoutTests/fast/css/area-computedStyle-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <style>

	5 area:hover {

	6 color: blue;

	7 }

	8 </style>

	9 </head>

	10 <body onload="runtest()">
	Inactive 2014/08/07 15:34:22 runTest() runTest()
	11 <map name="imagemap1">

	12 <area id="areaTest" onmouseover="hoverFunc()" shape="rect" coords="0, 0, 100 , 100" />

	13 </map>

	14 <img src="resources/greenbox-100px.png" border="0" align="left" usemap="#image map1" />

	15 <script src="../../resources/js-test.js"></script>
	Inactive 2014/08/07 15:34:22 Since you have a head, can you please move this to Since you have a head, can you please move this to the head section?
	16 <script>
	Inactive 2014/08/07 15:34:22 It seems like all this <script> could have stayed It seems like all this <script> could have stayed in the <head> if you did the getElementById() in runTest(). Only the variable needs to be declared at global scope. The getElementById() call can stay in the function.
	17 description("Test return value of getComputedStyle() for area tag.");

	18 window.jsTestIsAsync = true;

	19 var areatag = document.getElementById("areaTest");
	Inactive 2014/08/07 15:34:22 this is not a tag, so either "area" or "areaElemen this is not a tag, so either "area" or "areaElement".
	20

	21 function runtest() {
	Inactive 2014/08/07 15:34:22 "runTest()" "runTest()"
	22 if(window.eventSender) {
	Inactive 2014/08/07 15:34:22 missing space after "if" missing space after "if"
	23 var target = document.getElementById("areaTest");

	24 var x = target.offsetParent.offsetLeft + target.offsetLeft + target.offset Width / 2;

	25 var y = target.offsetParent.offsetTop + target.offsetTop + target.offsetHe ight / 2;

	26 eventSender.mouseMoveTo(x, y);

	27 }

	28 }

	29

	30 function hoverFunc() {
	Inactive 2014/08/07 15:34:22 maybe onAreaHover() ? maybe onAreaHover() ?
	31 shouldBeEqualToString("window.getComputedStyle(areatag, null).color", "rgb(0, 0, 255)");

	32 finishJSTest();

	33 }

	34 </script>

	35 </body>

	36 </html>

OLD	NEW