Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 442483002: Avoid redundant allocation of accessor names. (Closed)

Created:
6 years, 4 months ago by koda
Modified:
6 years, 4 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Avoid redundant allocation of accessor names. Support prefixed lookup in symbol table. Startup new gen usage after "hello world" startup is reduced by ~15%. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=38884

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -12 lines) Patch
M runtime/vm/object.h View 4 chunks +8 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 4 chunks +39 lines, -11 lines 0 comments Download
M runtime/vm/object_test.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M runtime/vm/symbols.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/symbols.cc View 5 chunks +39 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
koda
6 years, 4 months ago (2014-08-04 18:45:47 UTC) #1
Ivan Posva
LGTM -ip
6 years, 4 months ago (2014-08-04 20:51:54 UTC) #2
koda
6 years, 4 months ago (2014-08-04 23:04:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r38884 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698