Issue 44243003: Devirtualize WebKitSourceBuffer's destructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 44243003: Devirtualize WebKitSourceBuffer's destructor (Closed)

Created:
7 years, 1 month ago by Inactive

Modified:
7 years, 1 month ago

Reviewers:
acolwell GONE FROM CHROMIUM, abarth-chromium

CC:
blink-reviews, feature-media-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Devirtualize WebKitSourceBuffer's destructor Devirtualize WebKitSourceBuffer's destructor. This avoids creating an unnecessary vtable as this class is never subclassed nor does it have any virtual function. BUG=311561 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160608

Patch Set 1 #

Patch Set 2 : Build fix #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/modules/mediasource/WebKitSourceBuffer.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/44243003/30001

7 years, 1 month ago (2013-10-25 18:06:58 UTC) #3

Message was sent while issue was closed.

Change committed as 160608

Expand Messages | Collapse Messages