Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Issue 442423002: Update third_party/chromite to include latest build fixes. (Closed)

Created:
6 years, 4 months ago by Ilya Sherman
Modified:
6 years, 4 months ago
Reviewers:
Nico, Daniel Erat
CC:
chromium-reviews, Daniel Erat, jonross, stevenjb, vapier, xiyuan
Project:
chromium
Visibility:
Public.

Description

Update third_party/chromite to include latest build fixes. BUG=400484 R=thakis@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287838

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
Ilya Sherman
6 years, 4 months ago (2014-08-06 17:31:55 UTC) #1
Daniel Erat
lgtm
6 years, 4 months ago (2014-08-06 17:34:37 UTC) #2
Nico
lgtm
6 years, 4 months ago (2014-08-06 17:36:26 UTC) #3
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 4 months ago (2014-08-06 17:40:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/442423002/1
6 years, 4 months ago (2014-08-06 17:42:02 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-06 17:51:11 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-06 17:52:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/48832) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/38079) win_gpu ...
6 years, 4 months ago (2014-08-06 17:52:30 UTC) #8
Nico
This sadly conflicted with https://codereview.chromium.org/445833002 . Your revision is newer than what derat rolled to ...
6 years, 4 months ago (2014-08-06 18:02:11 UTC) #9
Daniel Erat
yeah, sorry. would've included this change if i knew it was needed, but pulling in ...
6 years, 4 months ago (2014-08-06 18:49:49 UTC) #10
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 4 months ago (2014-08-06 19:11:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/442423002/20001
6 years, 4 months ago (2014-08-06 19:12:49 UTC) #12
Nico
The CQ bit was unchecked by thakis@chromium.org
6 years, 4 months ago (2014-08-06 20:00:57 UTC) #13
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 4 months ago (2014-08-06 20:01:07 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/442423002/20001
6 years, 4 months ago (2014-08-06 20:04:03 UTC) #15
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 20:05:53 UTC) #16
Message was sent while issue was closed.
Change committed as 287838

Powered by Google App Engine
This is Rietveld 408576698