Update SyncManager::Init to use a GURL for the sync server URL.

Refactor SyncManager::Init to use a GURL for the sync server URL.

Instead of passing the sync server URL as a string, int, and bool, just
pass the GURL.  In a future CL SyncManager will make use of this GURL to
initialize an AttachmentUploader.

clang-format was used to format the modified lines.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287893

[maniscalco, 2014-08-06 17:43:00]

Haitao, would you please review this change?

[haitaol1, 2014-08-06 21:30:26]

https://codereview.chromium.org/442403003/diff/40001/sync/internal_api/sync_m...
File sync/internal_api/sync_manager_impl.cc (right):

https://codereview.chromium.org/442403003/diff/40001/sync/internal_api/sync_m...
sync/internal_api/sync_manager_impl.cc:387: service_url.host() +
service_url.path(),
Why don't continue to pass down GURL?

[maniscalco, 2014-08-06 21:33:40]

https://codereview.chromium.org/442403003/diff/40001/sync/internal_api/sync_m...
File sync/internal_api/sync_manager_impl.cc (right):

https://codereview.chromium.org/442403003/diff/40001/sync/internal_api/sync_m...
sync/internal_api/sync_manager_impl.cc:387: service_url.host() +
service_url.path(),
On 2014/08/06 21:30:26, haitaol1 wrote:
> Why don't continue to pass down GURL?

No reason other than I don't need it any deeper at this point.  In the future,
if I do (or I have extra time to do more cleanup), I'll continue plumbing it
through.

[haitaol1, 2014-08-06 22:09:13]

lgtm

[maniscalco, 2014-08-06 22:11:31]

On 2014/08/06 22:09:13, haitaol1 wrote:
> lgtm

Thanks for the speedy review.

[maniscalco, 2014-08-06 22:11:35]

The CQ bit was checked by maniscalco@chromium.org

[commit-bot: I haz the power, 2014-08-06 22:14:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/maniscalco@chromium.org/442403003/40001

[commit-bot: I haz the power, 2014-08-06 23:22:43]

Change committed as 287893