Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: components/autofill/core/browser/autofill_field.h

Issue 442403002: Adjust displayed phone number for prefix/suffix case. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Upload code as per review comments. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_FIELD_H_ 5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_FIELD_H_
6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_FIELD_H_ 6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_FIELD_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 // Set |field_data|'s value to |value|. Uses |field|, |address_language_code|, 68 // Set |field_data|'s value to |value|. Uses |field|, |address_language_code|,
69 // and |app_locale| as hints when filling exceptional cases like phone number 69 // and |app_locale| as hints when filling exceptional cases like phone number
70 // values and <select> fields. Returns |true| if the field has been filled, 70 // values and <select> fields. Returns |true| if the field has been filled,
71 // |false| otherwise. 71 // |false| otherwise.
72 static bool FillFormField(const AutofillField& field, 72 static bool FillFormField(const AutofillField& field,
73 const base::string16& value, 73 const base::string16& value,
74 const std::string& address_language_code, 74 const std::string& address_language_code,
75 const std::string& app_locale, 75 const std::string& app_locale,
76 FormFieldData* field_data); 76 FormFieldData* field_data);
77 77
78 // Get value for phone number. The value could be |number|, or possibly an
79 // appropriate substring of |number| if it's for phone prefix or suffix field.
Ilya Sherman 2014/09/11 05:32:14 nit: Suggested rephrasing; feel free to further im
ziran.sun 2014/09/22 13:46:33 Done.
80 static base::string16 GetPhoneNumberValue(const AutofillField& field,
81 const base::string16& number,
82 const FormFieldData& field_data);
83
78 private: 84 private:
79 // The unique name of this field, generated by Autofill. 85 // The unique name of this field, generated by Autofill.
80 base::string16 unique_name_; 86 base::string16 unique_name_;
81 87
82 // The unique identifier for the section (e.g. billing vs. shipping address) 88 // The unique identifier for the section (e.g. billing vs. shipping address)
83 // that this field belongs to. 89 // that this field belongs to.
84 std::string section_; 90 std::string section_;
85 91
86 // The type of the field, as determined by the Autofill server. 92 // The type of the field, as determined by the Autofill server.
87 ServerFieldType server_type_; 93 ServerFieldType server_type_;
(...skipping 16 matching lines...) Expand all
104 110
105 // The default value returned by the Autofill server. 111 // The default value returned by the Autofill server.
106 std::string default_value_; 112 std::string default_value_;
107 113
108 DISALLOW_COPY_AND_ASSIGN(AutofillField); 114 DISALLOW_COPY_AND_ASSIGN(AutofillField);
109 }; 115 };
110 116
111 } // namespace autofill 117 } // namespace autofill
112 118
113 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_FIELD_H_ 119 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_FIELD_H_
OLDNEW
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_field.cc » ('j') | components/autofill/core/browser/autofill_field.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698