Files.app: Add units test of FileOperationManager#paste.

Files.app: Add units test of FileOperationManager#paste.

BUG=315439
TEST=manually

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288317

[hirono, 2014-08-07 08:55:46]

PTAL the CL? Thank you!

[yoshiki, 2014-08-07 09:35:30]

https://codereview.chromium.org/442393003/diff/20001/chrome/test/data/file_ma...
File chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js
(right):

https://codereview.chromium.org/442393003/diff/20001/chrome/test/data/file_ma...
chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js:22:
this.keepAwakeRequested = true;
Don't use 'this' here, since 'this' is not an instance.

You should write like:
chrome.power.keepAwakeRequested = true;

https://codereview.chromium.org/442393003/diff/20001/chrome/test/data/file_ma...
chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js:25:
this.keepAwakeRequested = false;
ditto

https://codereview.chromium.org/442393003/diff/20001/chrome/test/data/file_ma...
chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js:38:
this.listener_ = callback;
ditto

https://codereview.chromium.org/442393003/diff/20001/chrome/test/data/file_ma...
chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js:41:
this.listener_ = null;
ditto

https://codereview.chromium.org/442393003/diff/20001/chrome/test/data/file_ma...
chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js:57:
this.onCopyProgress.listener_.apply(null, events[index]);
ditto

https://codereview.chromium.org/442393003/diff/20001/chrome/test/data/file_ma...
chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js:201:
[new MockFileEntry('testVolume', '/test.txt', {size: 10})];
nit: 4 space indent

https://codereview.chromium.org/442393003/diff/20001/chrome/test/data/file_ma...
chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js:204:
if (url == sourceEntries[0].toURL())
nit ===

https://codereview.chromium.org/442393003/diff/20001/chrome/test/data/file_ma...
chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js:206:
else if (url == targetEntry.toURL())
ditto

https://codereview.chromium.org/442393003/diff/20001/chrome/test/data/file_ma...
chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js:208:
else {
If you uses curly brackets here, please use curly brackets in all if (and
else-if) blocks above.

https://codereview.chromium.org/442393003/diff/20001/chrome/test/data/file_ma...
chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js:209:
console.log('Cannot find ' + url + '.');
Please use 'console.error' if it's an error.

https://codereview.chromium.org/442393003/diff/20001/chrome/test/data/file_ma...
File chrome/test/data/file_manager/unit_tests/mocks/mock_entry.js (right):

https://codereview.chromium.org/442393003/diff/20001/chrome/test/data/file_ma...
chrome/test/data/file_manager/unit_tests/mocks/mock_entry.js:4: 
jsdoc

https://codereview.chromium.org/442393003/diff/20001/chrome/test/data/file_ma...
chrome/test/data/file_manager/unit_tests/mocks/mock_entry.js:43:
console.log(error);
Please use 'console.error' if it's an error.

https://codereview.chromium.org/442393003/diff/20001/chrome/test/data/file_ma...
chrome/test/data/file_manager/unit_tests/mocks/mock_entry.js:54: *     path and
MockEntry contained in the directory.
nit: @extends {MockEntry}

[hirono, 2014-08-08 03:37:41]

Thank you!

https://codereview.chromium.org/442393003/diff/20001/chrome/test/data/file_ma...
File chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js
(right):

https://codereview.chromium.org/442393003/diff/20001/chrome/test/data/file_ma...
chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js:22:
this.keepAwakeRequested = true;
On 2014/08/07 09:35:29, yoshiki wrote:
> Don't use 'this' here, since 'this' is not an instance.
> 
> You should write like:
> chrome.power.keepAwakeRequested = true;

Done.

https://codereview.chromium.org/442393003/diff/20001/chrome/test/data/file_ma...
chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js:25:
this.keepAwakeRequested = false;
On 2014/08/07 09:35:29, yoshiki wrote:
> ditto

Done.

https://codereview.chromium.org/442393003/diff/20001/chrome/test/data/file_ma...
chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js:38:
this.listener_ = callback;
On 2014/08/07 09:35:29, yoshiki wrote:
> ditto

Done.

https://codereview.chromium.org/442393003/diff/20001/chrome/test/data/file_ma...
chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js:41:
this.listener_ = null;
On 2014/08/07 09:35:29, yoshiki wrote:
> ditto

Done.

https://codereview.chromium.org/442393003/diff/20001/chrome/test/data/file_ma...
chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js:57:
this.onCopyProgress.listener_.apply(null, events[index]);
On 2014/08/07 09:35:29, yoshiki wrote:
> ditto

Done.

https://codereview.chromium.org/442393003/diff/20001/chrome/test/data/file_ma...
chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js:201:
[new MockFileEntry('testVolume', '/test.txt', {size: 10})];
On 2014/08/07 09:35:30, yoshiki wrote:
> nit: 4 space indent

I counted 4 spaces from the head of 'var' in the previous line.
Does it make sense?

https://codereview.chromium.org/442393003/diff/20001/chrome/test/data/file_ma...
chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js:204:
if (url == sourceEntries[0].toURL())
On 2014/08/07 09:35:29, yoshiki wrote:
> nit ===

Done.

https://codereview.chromium.org/442393003/diff/20001/chrome/test/data/file_ma...
chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js:206:
else if (url == targetEntry.toURL())
On 2014/08/07 09:35:30, yoshiki wrote:
> ditto

Done.

https://codereview.chromium.org/442393003/diff/20001/chrome/test/data/file_ma...
chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js:208:
else {
On 2014/08/07 09:35:29, yoshiki wrote:
> If you uses curly brackets here, please use curly brackets in all if (and
> else-if) blocks above.

Done.

https://codereview.chromium.org/442393003/diff/20001/chrome/test/data/file_ma...
chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js:209:
console.log('Cannot find ' + url + '.');
On 2014/08/07 09:35:29, yoshiki wrote:
> Please use 'console.error' if it's an error.

Let me remove the line. This is the debug log.

https://codereview.chromium.org/442393003/diff/20001/chrome/test/data/file_ma...
File chrome/test/data/file_manager/unit_tests/mocks/mock_entry.js (right):

https://codereview.chromium.org/442393003/diff/20001/chrome/test/data/file_ma...
chrome/test/data/file_manager/unit_tests/mocks/mock_entry.js:4: 
On 2014/08/07 09:35:30, yoshiki wrote:
> jsdoc

Done.

https://codereview.chromium.org/442393003/diff/20001/chrome/test/data/file_ma...
chrome/test/data/file_manager/unit_tests/mocks/mock_entry.js:43:
console.log(error);
On 2014/08/07 09:35:30, yoshiki wrote:
> Please use 'console.error' if it's an error.

Done.

https://codereview.chromium.org/442393003/diff/20001/chrome/test/data/file_ma...
chrome/test/data/file_manager/unit_tests/mocks/mock_entry.js:54: *     path and
MockEntry contained in the directory.
On 2014/08/07 09:35:30, yoshiki wrote:
> nit: @extends {MockEntry}

Done.

[yoshiki, 2014-08-08 04:36:42]

lgtm

https://codereview.chromium.org/442393003/diff/40001/chrome/test/data/file_ma...
File chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js
(right):

https://codereview.chromium.org/442393003/diff/40001/chrome/test/data/file_ma...
chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js:56:
return Promise.resolve().then(function() {
Why do you use Promise.resolve()? (maybe make it async?) If it's your intention,
please add the comment.

https://codereview.chromium.org/442393003/diff/40001/chrome/test/data/file_ma...
chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js:218:
if (event.reason == 'SUCCESS')
nit: ===

[hirono, 2014-08-08 04:56:19]

Thank you!

https://codereview.chromium.org/442393003/diff/40001/chrome/test/data/file_ma...
File chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js
(right):

https://codereview.chromium.org/442393003/diff/40001/chrome/test/data/file_ma...
chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js:56:
return Promise.resolve().then(function() {
On 2014/08/08 04:36:42, yoshiki wrote:
> Why do you use Promise.resolve()? (maybe make it async?) If it's your
intention,
> please add the comment.

Done.

https://codereview.chromium.org/442393003/diff/40001/chrome/test/data/file_ma...
chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js:218:
if (event.reason == 'SUCCESS')
On 2014/08/08 04:36:42, yoshiki wrote:
> nit: ===

Done.

[hirono, 2014-08-08 04:56:22]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2014-08-08 04:58:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hirono@chromium.org/442393003/60001

[commit-bot: I haz the power, 2014-08-08 10:40:52]

Change committed as 288317