Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Side by Side Diff: content/browser/fileapi/sandbox_file_system_backend_delegate_unittest.cc

Issue 442383002: Move storage-related files from webkit/ to new top-level directory storage/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "webkit/browser/fileapi/sandbox_file_system_backend_delegate.h" 5 #include "storage/browser/fileapi/sandbox_file_system_backend_delegate.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/file_util.h" 8 #include "base/file_util.h"
9 #include "base/files/scoped_temp_dir.h" 9 #include "base/files/scoped_temp_dir.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
11 #include "base/message_loop/message_loop.h" 11 #include "base/message_loop/message_loop.h"
12 #include "base/message_loop/message_loop_proxy.h" 12 #include "base/message_loop/message_loop_proxy.h"
13 #include "content/public/test/test_file_system_options.h" 13 #include "content/public/test/test_file_system_options.h"
14 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
15 #include "url/gurl.h" 15 #include "url/gurl.h"
16 #include "webkit/browser/fileapi/file_system_url.h" 16 #include "storage/browser/fileapi/file_system_url.h"
17 17
18 using fileapi::FileSystemURL; 18 using storage::FileSystemURL;
19 19
20 namespace content { 20 namespace content {
21 21
22 namespace { 22 namespace {
23 23
24 FileSystemURL CreateFileSystemURL(const char* path) { 24 FileSystemURL CreateFileSystemURL(const char* path) {
25 const GURL kOrigin("http://foo/"); 25 const GURL kOrigin("http://foo/");
26 return fileapi::FileSystemURL::CreateForTest( 26 return storage::FileSystemURL::CreateForTest(
27 kOrigin, fileapi::kFileSystemTypeTemporary, 27 kOrigin,
28 storage::kFileSystemTypeTemporary,
28 base::FilePath::FromUTF8Unsafe(path)); 29 base::FilePath::FromUTF8Unsafe(path));
29 } 30 }
30 31
31 } // namespace 32 } // namespace
32 33
33 class SandboxFileSystemBackendDelegateTest : public testing::Test { 34 class SandboxFileSystemBackendDelegateTest : public testing::Test {
34 protected: 35 protected:
35 virtual void SetUp() { 36 virtual void SetUp() {
36 ASSERT_TRUE(data_dir_.CreateUniqueTempDir()); 37 ASSERT_TRUE(data_dir_.CreateUniqueTempDir());
37 delegate_.reset(new fileapi::SandboxFileSystemBackendDelegate( 38 delegate_.reset(new storage::SandboxFileSystemBackendDelegate(
38 NULL /* quota_manager_proxy */, 39 NULL /* quota_manager_proxy */,
39 base::MessageLoopProxy::current().get(), 40 base::MessageLoopProxy::current().get(),
40 data_dir_.path(), 41 data_dir_.path(),
41 NULL /* special_storage_policy */, 42 NULL /* special_storage_policy */,
42 CreateAllowFileAccessOptions())); 43 CreateAllowFileAccessOptions()));
43 } 44 }
44 45
45 bool IsAccessValid(const FileSystemURL& url) const { 46 bool IsAccessValid(const FileSystemURL& url) const {
46 return delegate_->IsAccessValid(url); 47 return delegate_->IsAccessValid(url);
47 } 48 }
48 49
49 base::ScopedTempDir data_dir_; 50 base::ScopedTempDir data_dir_;
50 base::MessageLoop message_loop_; 51 base::MessageLoop message_loop_;
51 scoped_ptr<fileapi::SandboxFileSystemBackendDelegate> delegate_; 52 scoped_ptr<storage::SandboxFileSystemBackendDelegate> delegate_;
52 }; 53 };
53 54
54 TEST_F(SandboxFileSystemBackendDelegateTest, IsAccessValid) { 55 TEST_F(SandboxFileSystemBackendDelegateTest, IsAccessValid) {
55 // Normal case. 56 // Normal case.
56 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL("a"))); 57 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL("a")));
57 58
58 // Access to a path with parent references ('..') should be disallowed. 59 // Access to a path with parent references ('..') should be disallowed.
59 EXPECT_FALSE(IsAccessValid(CreateFileSystemURL("a/../b"))); 60 EXPECT_FALSE(IsAccessValid(CreateFileSystemURL("a/../b")));
60 61
61 // Access from non-allowed scheme should be disallowed. 62 // Access from non-allowed scheme should be disallowed.
62 EXPECT_FALSE(IsAccessValid( 63 EXPECT_FALSE(IsAccessValid(
63 FileSystemURL::CreateForTest( 64 FileSystemURL::CreateForTest(GURL("unknown://bar"),
64 GURL("unknown://bar"), fileapi::kFileSystemTypeTemporary, 65 storage::kFileSystemTypeTemporary,
65 base::FilePath::FromUTF8Unsafe("foo")))); 66 base::FilePath::FromUTF8Unsafe("foo"))));
66 67
67 // Access with restricted name should be disallowed. 68 // Access with restricted name should be disallowed.
68 EXPECT_FALSE(IsAccessValid(CreateFileSystemURL("."))); 69 EXPECT_FALSE(IsAccessValid(CreateFileSystemURL(".")));
69 EXPECT_FALSE(IsAccessValid(CreateFileSystemURL(".."))); 70 EXPECT_FALSE(IsAccessValid(CreateFileSystemURL("..")));
70 71
71 // This is also disallowed due to Windows XP parent path handling. 72 // This is also disallowed due to Windows XP parent path handling.
72 EXPECT_FALSE(IsAccessValid(CreateFileSystemURL("..."))); 73 EXPECT_FALSE(IsAccessValid(CreateFileSystemURL("...")));
73 74
74 // These are identified as unsafe cases due to weird path handling 75 // These are identified as unsafe cases due to weird path handling
75 // on Windows. 76 // on Windows.
76 EXPECT_FALSE(IsAccessValid(CreateFileSystemURL(" .."))); 77 EXPECT_FALSE(IsAccessValid(CreateFileSystemURL(" ..")));
77 EXPECT_FALSE(IsAccessValid(CreateFileSystemURL(".. "))); 78 EXPECT_FALSE(IsAccessValid(CreateFileSystemURL(".. ")));
78 79
79 // Similar but safe cases. 80 // Similar but safe cases.
80 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL(" ."))); 81 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL(" .")));
81 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL(". "))); 82 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL(". ")));
82 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL("b."))); 83 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL("b.")));
83 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL(".b"))); 84 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL(".b")));
84 85
85 // A path that looks like a drive letter. 86 // A path that looks like a drive letter.
86 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL("c:"))); 87 EXPECT_TRUE(IsAccessValid(CreateFileSystemURL("c:")));
87 } 88 }
88 89
89 } // namespace content 90 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698