Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 442363002: Add a parameter to return continuations (Closed)

Created:
6 years, 4 months ago by jgruber1
Modified:
6 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a parameter to return continuations Every return continuation has exactly one parameter. It will be used during constant propagation to unify handling of constant continuation parameters. BUG= R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=39026

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jgruber1
6 years, 4 months ago (2014-08-06 15:02:06 UTC) #1
Kevin Millikin (Google)
lgtm https://codereview.chromium.org/442363002/diff/1/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes.dart File sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes.dart (right): https://codereview.chromium.org/442363002/diff/1/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes.dart#newcode509 sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes.dart:509: Continuation.retrn() : parameters = new List<Parameter>(1) { = ...
6 years, 4 months ago (2014-08-08 08:44:53 UTC) #2
jgruber1
https://codereview.chromium.org/442363002/diff/1/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes.dart File sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes.dart (right): https://codereview.chromium.org/442363002/diff/1/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes.dart#newcode509 sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes.dart:509: Continuation.retrn() : parameters = new List<Parameter>(1) { On 2014/08/08 ...
6 years, 4 months ago (2014-08-08 09:04:03 UTC) #3
jgruber1
6 years, 4 months ago (2014-08-08 09:05:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as 39026 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698