Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 442343004: Bye bye bench. (Closed)

Created:
6 years, 4 months ago by mtklein_C
Modified:
6 years, 4 months ago
Reviewers:
djsollen, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Bye bye bench. NOTREECHECKS=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/be21e3432e4cf925fe494efe23edcb457bd05fcb

Patch Set 1 #

Patch Set 2 : android make #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1109 lines) Patch
D bench/bench_util.py View 1 chunk +0 lines, -356 lines 0 comments Download
D bench/benchmain.cpp View 1 chunk +0 lines, -716 lines 0 comments Download
M gyp/bench.gyp View 1 chunk +0 lines, -28 lines 0 comments Download
M platform_tools/android/bin/gyp_to_android.py View 1 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mtklein
6 years, 4 months ago (2014-08-06 15:20:13 UTC) #1
djsollen
lgtm
6 years, 4 months ago (2014-08-06 15:21:47 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-08-06 15:22:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/442343004/20001
6 years, 4 months ago (2014-08-06 15:23:48 UTC) #4
mtklein
The CQ bit was unchecked by mtklein@google.com
6 years, 4 months ago (2014-08-06 15:39:24 UTC) #5
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-08-06 15:39:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/442343004/20001
6 years, 4 months ago (2014-08-06 15:39:31 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 15:39:48 UTC) #8
Message was sent while issue was closed.
Change committed as be21e3432e4cf925fe494efe23edcb457bd05fcb

Powered by Google App Engine
This is Rietveld 408576698