Chromium Code Reviews| Index: ui/events/keycodes/keyboard_code_conversion_x.cc |
| diff --git a/ui/events/keycodes/keyboard_code_conversion_x.cc b/ui/events/keycodes/keyboard_code_conversion_x.cc |
| index efbf1d427e47edd5b6e9071e8a3d9aff1f1d85c7..be3ba330314ce0268b6be61e43dba6d05b306751 100644 |
| --- a/ui/events/keycodes/keyboard_code_conversion_x.cc |
| +++ b/ui/events/keycodes/keyboard_code_conversion_x.cc |
| @@ -765,8 +765,6 @@ KeyboardCode KeyboardCodeFromXKeysym(unsigned int keysym) { |
| // https://bugs.freedesktop.org/show_bug.cgi?id=5783 |
| // In Chrome, we map these X key symbols back to F13-18 since we don't have |
| // VKEYs for these XF86XK symbols. |
| - case XF86XK_Tools: |
| - return VKEY_F13; |
| case XF86XK_Launch5: |
| return VKEY_F14; |
| case XF86XK_Launch6: |
| @@ -814,6 +812,13 @@ KeyboardCode KeyboardCodeFromXKeysym(unsigned int keysym) { |
| case XF86XK_LaunchB: // F4 on an Apple keyboard. |
| case XF86XK_Calculator: |
| return VKEY_MEDIA_LAUNCH_APP2; |
| + |
| + // XF86XK_Tools is generated from HID Usage AL_CONSUMER_CONTROL_CONFIG |
| + // (Usage 0x0183, Page 0x0C) and most commonly launches the OS default |
| + // media player (see crbug/398345). |
|
Wez
2014/09/02 17:27:18
s/crbug/crbug.com
mmeisser
2014/09/09 14:20:52
Should I change something here ?
Wez
2014/09/10 03:38:51
Yes, please update the comment to say "(see crbug.
|
| + case XF86XK_Tools: |
| + return VKEY_MEDIA_LAUNCH_MEDIA_SELECT; |
| + |
| case XF86XK_WLAN: |
| return VKEY_WLAN; |
| case XF86XK_PowerOff: |