Fixed odd behavior for keyboards using the AL_CONSUMER_CONTROL_CONFIG

ui/events/keycodes/keyboard_code_conversion_x.cc

Index: ui/events/keycodes/keyboard_code_conversion_x.cc
diff --git a/ui/events/keycodes/keyboard_code_conversion_x.cc b/ui/events/keycodes/keyboard_code_conversion_x.cc
index efbf1d427e47edd5b6e9071e8a3d9aff1f1d85c7..14b76f293e925b8c3b3a9055f566b16a20ef40e2 100644
--- a/ui/events/keycodes/keyboard_code_conversion_x.cc
+++ b/ui/events/keycodes/keyboard_code_conversion_x.cc
@@ -765,8 +765,6 @@ KeyboardCode KeyboardCodeFromXKeysym(unsigned int keysym) {
     // https://bugs.freedesktop.org/show_bug.cgi?id=5783
     // In Chrome, we map these X key symbols back to F13-18 since we don't have
     // VKEYs for these XF86XK symbols.
-    case XF86XK_Tools:
-      return VKEY_F13;
     case XF86XK_Launch5:
       return VKEY_F14;
     case XF86XK_Launch6:
@@ -778,6 +776,13 @@ KeyboardCode KeyboardCodeFromXKeysym(unsigned int keysym) {
     case XF86XK_Launch9:
       return VKEY_F18;
 
+    // this was mapped to VKEY_F13 (see above), but this was causing odd

[Wez, 2014/08/06 21:17:53]

nit: Capitalization.

+    // behavior (trig lock screen) with all keyboard that send this usage
+    // in order to launch the media player(supported on Windows, Android)
+    // (see crbug=398345)

[Wez, 2014/08/06 21:17:53]

nit: Rather than describe the bug, describe the logic behind mapping "Tools" to
"Select Media", i.e. why this mapping? 

[mmeisser, 2014/08/07 17:46:41]

I will describe the mapping. This seems odd, but already the XK86XK_Tools is a
weird naming for AL_CONSUMER_CONTROL_CONFIG (0x0C 0x0183) in the first place.
The second weird thing is that this is used in Windows and Android in order to
launch a media player app. Multiple keyboards in the field (not only logitech's)
are using this usage on a hotkey with a music icon.

+    case XF86XK_Tools:

[Wez, 2014/08/06 21:17:53]

Can you move this to the appropriate order in this switch, i.e. near to whatever
the closest other XK values handled are?

[mmeisser, 2014/08/07 17:46:41]

The actual list of XK mappings are not really ordered in terms of values, rather
on meaning/features. But I guess putting this closer to launchA & co makes sense
since
those are the closer values and do belong to the same feature-set (ie launch an
app).

+      return VKEY_MEDIA_LAUNCH_MEDIA_SELECT;
+
     // For supporting multimedia buttons on a USB keyboard.
     case XF86XK_Back:
       return VKEY_BROWSER_BACK;