Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 442313002: Contentbrowsertest for verifying that a black frame is sent on a peerconnection if a track is disab… (Closed)

Created:
6 years, 4 months ago by perkj_chrome
Modified:
6 years, 4 months ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Content browsertest for verifying that a black frame is sent on a peerconnection if a track is disabled. BUG=398844 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288702

Patch Set 1 : Rebased #

Patch Set 2 : Addressed nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M content/browser/media/webrtc_browsertest.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/test/data/media/peerconnection-call.html View 1 1 chunk +14 lines, -0 lines 0 comments Download
M content/test/data/media/webrtc_test_utilities.js View 3 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
phoglund_chromium
Unit test and browser test lgtm with nits; you may want to get a second ...
6 years, 4 months ago (2014-08-11 09:26:14 UTC) #1
perkj_chrome
This cl was only meant to include the test and utility changes. Fixed the code ...
6 years, 4 months ago (2014-08-11 10:04:17 UTC) #2
perkj_chrome
The CQ bit was checked by perkj@chromium.org
6 years, 4 months ago (2014-08-11 10:04:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/perkj@chromium.org/442313002/70004
6 years, 4 months ago (2014-08-11 10:05:01 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 14:09:25 UTC) #5
Message was sent while issue was closed.
Change committed as 288702

Powered by Google App Engine
This is Rietveld 408576698