chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc - Issue 442303002: DevTools: migrate DevTools APIs to use WebContents instead of RenderViewHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc

Issue 442303002: DevTools: migrate DevTools APIs to use WebContents instead of RenderViewHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review comments addressed. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/app_browsertest.cc ('k') | chrome/browser/devtools/browser_list_tabcontents_provider.cc » ('j') | chrome/browser/ui/webui/extensions/extension_error_ui_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc

diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc b/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc

index 5a76b20b31ce4a81ba42c8808fabf963e993aaec..6915f40ac0db822ad4b5f48a66638759161ad471 100644

--- a/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc

+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc

@@ -457,17 +457,20 @@ bool FileBrowserPrivateOpenInspectorFunction::RunSync() {

switch (params->type) {

case extensions::api::file_browser_private::INSPECTION_TYPE_NORMAL:

// Open inspector for foreground page.

- DevToolsWindow::OpenDevToolsWindow(render_view_host());

+ DevToolsWindow::OpenDevToolsWindow(

+ content::WebContents::FromRenderViewHost(render_view_host()));

break;

case extensions::api::file_browser_private::INSPECTION_TYPE_CONSOLE:

// Open inspector for foreground page and bring focus to the console.

- DevToolsWindow::OpenDevToolsWindow(render_view_host(),

- DevToolsToggleAction::ShowConsole());

+ DevToolsWindow::OpenDevToolsWindow(

+ content::WebContents::FromRenderViewHost(render_view_host()),

+ DevToolsToggleAction::ShowConsole());

break;

case extensions::api::file_browser_private::INSPECTION_TYPE_ELEMENT:

// Open inspector for foreground page in inspect element mode.

- DevToolsWindow::OpenDevToolsWindow(render_view_host(),

- DevToolsToggleAction::Inspect());

+ DevToolsWindow::OpenDevToolsWindow(

+ content::WebContents::FromRenderViewHost(render_view_host()),

+ DevToolsToggleAction::Inspect());

break;

case extensions::api::file_browser_private::INSPECTION_TYPE_BACKGROUND:

// Open inspector for background page.