content/browser/devtools/renderer_overrides_handler_browsertest.cc - Issue 442303002: DevTools: migrate DevTools APIs to use WebContents instead of RenderViewHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/renderer_overrides_handler_browsertest.cc

Issue 442303002: DevTools: migrate DevTools APIs to use WebContents instead of RenderViewHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review comments addressed. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/devtools/render_view_devtools_agent_host.cc ('K') | « content/browser/devtools/renderer_overrides_handler.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | content/public/browser/devtools_agent_host.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/renderer_overrides_handler_browsertest.cc

diff --git a/content/browser/devtools/renderer_overrides_handler_browsertest.cc b/content/browser/devtools/renderer_overrides_handler_browsertest.cc

index 2a3a667c03ccfc5b21ded4f02c5f877ba2ce31a4..a6cd973bc1a3422d272c40ef652d372a075ae23b 100644

--- a/content/browser/devtools/renderer_overrides_handler_browsertest.cc

+++ b/content/browser/devtools/renderer_overrides_handler_browsertest.cc

@@ -59,9 +59,7 @@ class RendererOverridesHandlerTest : public ContentBrowserTest,

private:

virtual void SetUpOnMainThread() OVERRIDE {

DevToolsManager::GetInstance()->RegisterDevToolsClientHostFor(

- DevToolsAgentHost::GetOrCreateFor(

- shell()->web_contents()->GetRenderViewHost()).get(),

- this);

+ DevToolsAgentHost::GetOrCreateFor(shell()->web_contents()).get(), this);

}

virtual void TearDownOnMainThread() OVERRIDE {