content/browser/devtools/devtools_agent_host_impl.h - Issue 442303002: DevTools: migrate DevTools APIs to use WebContents instead of RenderViewHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/devtools_agent_host_impl.h

Issue 442303002: DevTools: migrate DevTools APIs to use WebContents instead of RenderViewHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review comments addressed. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/extensions/extension_error_ui_util.cc ('K') | « chrome/browser/ui/webui/extensions/extension_settings_handler.cc ('k') | content/browser/devtools/devtools_agent_host_impl.cc » ('j') | content/browser/devtools/render_view_devtools_agent_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/devtools_agent_host_impl.h

diff --git a/content/browser/devtools/devtools_agent_host_impl.h b/content/browser/devtools/devtools_agent_host_impl.h

index d0fad668b492522b6f0444cde903cc932d0fec08..d20a8b793505146e0fd147a43f5623a50f1bc9d1 100644

--- a/content/browser/devtools/devtools_agent_host_impl.h

+++ b/content/browser/devtools/devtools_agent_host_impl.h

@@ -47,11 +47,11 @@ class CONTENT_EXPORT DevToolsAgentHostImpl : public DevToolsAgentHost {

virtual std::string GetId() OVERRIDE;

- virtual RenderViewHost* GetRenderViewHost() OVERRIDE;

+ virtual WebContents* GetWebContents() OVERRIDE;

- virtual void DisconnectRenderViewHost() OVERRIDE;

+ virtual void DisconnectWebContents() OVERRIDE;

- virtual void ConnectRenderViewHost(RenderViewHost* rvh) OVERRIDE;

+ virtual void ConnectWebContents(WebContents* rvh) OVERRIDE;

virtual bool IsWorker() const OVERRIDE;