chrome/browser/ui/panels/panel.cc - Issue 442303002: DevTools: migrate DevTools APIs to use WebContents instead of RenderViewHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/panel.cc

Issue 442303002: DevTools: migrate DevTools APIs to use WebContents instead of RenderViewHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review comments addressed. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/devtools/devtools_window.cc ('K') | « chrome/browser/task_manager/task_manager.cc ('k') | chrome/browser/ui/views/extensions/extension_popup.cc » ('j') | chrome/browser/ui/webui/extensions/extension_error_ui_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/panels/panel.cc

diff --git a/chrome/browser/ui/panels/panel.cc b/chrome/browser/ui/panels/panel.cc

index f85704062064f3356085d05fd3f35be25441db9e..e1628df4c60fb2efc09d11e1e162fe6cf2ecd70f 100644

--- a/chrome/browser/ui/panels/panel.cc

+++ b/chrome/browser/ui/panels/panel.cc

@@ -415,15 +415,13 @@ void Panel::ExecuteCommandWithDisposition(int id,

// DevTools

case IDC_DEV_TOOLS:

content::RecordAction(UserMetricsAction("DevTools_ToggleWindow"));

- DevToolsWindow::OpenDevToolsWindow(

- GetWebContents()->GetRenderViewHost(),

- DevToolsToggleAction::Show());

+ DevToolsWindow::OpenDevToolsWindow(GetWebContents(),

+ DevToolsToggleAction::Show());

break;

case IDC_DEV_TOOLS_CONSOLE:

content::RecordAction(UserMetricsAction("DevTools_ToggleConsole"));

- DevToolsWindow::OpenDevToolsWindow(

- GetWebContents()->GetRenderViewHost(),

- DevToolsToggleAction::ShowConsole());

+ DevToolsWindow::OpenDevToolsWindow(GetWebContents(),

+ DevToolsToggleAction::ShowConsole());

break;

default: