chrome/browser/devtools/devtools_window_testing.h - Issue 442303002: DevTools: migrate DevTools APIs to use WebContents instead of RenderViewHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_window_testing.h

Issue 442303002: DevTools: migrate DevTools APIs to use WebContents instead of RenderViewHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review comments addressed. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/devtools/devtools_window.cc ('K') | « chrome/browser/devtools/devtools_window.cc ('k') | chrome/browser/devtools/devtools_window_testing.cc » ('j') | chrome/browser/ui/webui/extensions/extension_error_ui_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/devtools_window_testing.h

diff --git a/chrome/browser/devtools/devtools_window_testing.h b/chrome/browser/devtools/devtools_window_testing.h

index 38e5e73cb2665c4611d0a5d6ac0ad69e1629f611..c38d3a8160bbd8b6e80a16e22ed72b7966034443 100644

--- a/chrome/browser/devtools/devtools_window_testing.h

+++ b/chrome/browser/devtools/devtools_window_testing.h

@@ -14,7 +14,6 @@ class Profile;

namespace content {

class DevToolsAgentHost;

-class RenderViewHost;

class WebContents;

}

@@ -24,7 +23,8 @@ class DevToolsWindowTesting {

// The following methods block until DevToolsWindow is completely loaded.

static DevToolsWindow* OpenDevToolsWindowSync(

- content::RenderViewHost* inspected_rvh, bool is_docked);

+ content::WebContents* inspected_web_contents,

+ bool is_docked);

static DevToolsWindow* OpenDevToolsWindowSync(

Browser* browser, bool is_docked);

static DevToolsWindow* OpenDevToolsWindowForWorkerSync(