Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Unified Diff: chrome/browser/devtools/devtools_sanity_browsertest.cc

Issue 442303002: DevTools: migrate DevTools APIs to use WebContents instead of RenderViewHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review comments addressed. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_sanity_browsertest.cc
diff --git a/chrome/browser/devtools/devtools_sanity_browsertest.cc b/chrome/browser/devtools/devtools_sanity_browsertest.cc
index 5ae8a2725bf22b08850b36b7b489ddc2f56a039e..698cc8c4c86544bd547d17c8e1db70506dd63b2b 100644
--- a/chrome/browser/devtools/devtools_sanity_browsertest.cc
+++ b/chrome/browser/devtools/devtools_sanity_browsertest.cc
@@ -109,9 +109,7 @@ void RunTestFunction(DevToolsWindow* window, const char* test_name) {
class DevToolsSanityTest : public InProcessBrowserTest {
public:
- DevToolsSanityTest()
- : window_(NULL),
- inspected_rvh_(NULL) {}
+ DevToolsSanityTest() : window_(NULL) {}
protected:
void RunTest(const std::string& test_name, const std::string& test_page) {
@@ -129,9 +127,8 @@ class DevToolsSanityTest : public InProcessBrowserTest {
ASSERT_TRUE(test_server()->Start());
LoadTestPage(test_page);
- inspected_rvh_ = GetInspectedTab()->GetRenderViewHost();
- window_ = DevToolsWindowTesting::OpenDevToolsWindowSync(
- inspected_rvh_, is_docked);
+ window_ = DevToolsWindowTesting::OpenDevToolsWindowSync(GetInspectedTab(),
+ is_docked);
}
WebContents* GetInspectedTab() {
@@ -151,7 +148,6 @@ class DevToolsSanityTest : public InProcessBrowserTest {
}
DevToolsWindow* window_;
- RenderViewHost* inspected_rvh_;
};
// Used to block until a dev tools window gets beforeunload event.
@@ -246,8 +242,8 @@ class DevToolsBeforeUnloadTest: public DevToolsSanityTest {
DevToolsWindow* OpenDevToolWindowOnWebContents(
content::WebContents* contents, bool is_docked) {
- DevToolsWindow* window = DevToolsWindowTesting::OpenDevToolsWindowSync(
- contents->GetRenderViewHost(), is_docked);
+ DevToolsWindow* window =
+ DevToolsWindowTesting::OpenDevToolsWindowSync(contents, is_docked);
return window;
}
@@ -818,8 +814,8 @@ IN_PROC_BROWSER_TEST_F(DevToolsSanityTest, TestDevToolsExternalNavigation) {
IN_PROC_BROWSER_TEST_F(DevToolsSanityTest, TestToolboxLoadedUndocked) {
OpenDevToolsWindow(kDebuggerTestPage, false);
ASSERT_TRUE(toolbox_web_contents());
- DevToolsWindow* on_self = DevToolsWindowTesting::OpenDevToolsWindowSync(
- main_web_contents()->GetRenderViewHost(), false);
+ DevToolsWindow* on_self =
+ DevToolsWindowTesting::OpenDevToolsWindowSync(main_web_contents(), false);
ASSERT_FALSE(DevToolsWindowTesting::Get(on_self)->toolbox_web_contents());
DevToolsWindowTesting::CloseDevToolsWindowSync(on_self);
CloseDevToolsWindow();
@@ -829,8 +825,8 @@ IN_PROC_BROWSER_TEST_F(DevToolsSanityTest, TestToolboxLoadedUndocked) {
IN_PROC_BROWSER_TEST_F(DevToolsSanityTest, TestToolboxNotLoadedDocked) {
OpenDevToolsWindow(kDebuggerTestPage, true);
ASSERT_FALSE(toolbox_web_contents());
- DevToolsWindow* on_self = DevToolsWindowTesting::OpenDevToolsWindowSync(
- main_web_contents()->GetRenderViewHost(), false);
+ DevToolsWindow* on_self =
+ DevToolsWindowTesting::OpenDevToolsWindowSync(main_web_contents(), false);
ASSERT_FALSE(DevToolsWindowTesting::Get(on_self)->toolbox_web_contents());
DevToolsWindowTesting::CloseDevToolsWindowSync(on_self);
CloseDevToolsWindow();
@@ -896,9 +892,9 @@ class DevToolsAgentHostTest : public InProcessBrowserTest {};
// Tests DevToolsAgentHost retention by its target.
IN_PROC_BROWSER_TEST_F(DevToolsAgentHostTest, TestAgentHostReleased) {
ui_test_utils::NavigateToURL(browser(), GURL("about:blank"));
- RenderViewHost* rvh = browser()->tab_strip_model()->GetWebContentsAt(0)->
- GetRenderViewHost();
- DevToolsAgentHost* agent_raw = DevToolsAgentHost::GetOrCreateFor(rvh).get();
+ WebContents* web_contents = browser()->tab_strip_model()->GetWebContentsAt(0);
+ DevToolsAgentHost* agent_raw =
+ DevToolsAgentHost::GetOrCreateFor(web_contents).get();
const std::string agent_id = agent_raw->GetId();
ASSERT_EQ(agent_raw, DevToolsAgentHost::GetForId(agent_id)) <<
"DevToolsAgentHost cannot be found by id";

Powered by Google App Engine
This is Rietveld 408576698