chrome/browser/devtools/browser_list_tabcontents_provider.cc - Issue 442303002: DevTools: migrate DevTools APIs to use WebContents instead of RenderViewHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/browser_list_tabcontents_provider.cc

Issue 442303002: DevTools: migrate DevTools APIs to use WebContents instead of RenderViewHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review comments addressed. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/app_browsertest.cc ('k') | chrome/browser/devtools/chrome_devtools_manager_delegate.cc » ('j') | chrome/browser/devtools/devtools_target_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/browser_list_tabcontents_provider.cc

diff --git a/chrome/browser/devtools/browser_list_tabcontents_provider.cc b/chrome/browser/devtools/browser_list_tabcontents_provider.cc

index 5d98f6ccc0ca43e86b76c4ee7b583622f66b31ec..a4d18b3faaae939a6436c8bb145887d11fd6da44 100644

--- a/chrome/browser/devtools/browser_list_tabcontents_provider.cc

+++ b/chrome/browser/devtools/browser_list_tabcontents_provider.cc

@@ -119,11 +119,8 @@ BrowserListTabContentsProvider::CreateNewTarget(const GURL& url) {

url,

content::PAGE_TRANSITION_LINK);

}

- content::RenderViewHost* rvh = web_contents->GetRenderViewHost();

- if (!rvh)

- return scoped_ptr<DevToolsTarget>();

return scoped_ptr<DevToolsTarget>(

- DevToolsTargetImpl::CreateForRenderViewHost(rvh, true));

+ DevToolsTargetImpl::CreateForWebContents(web_contents, true));

}

void BrowserListTabContentsProvider::EnumerateTargets(TargetCallback callback) {