content/browser/renderer_host/render_widget_host_view_android.cc - Issue 442303002: DevTools: migrate DevTools APIs to use WebContents instead of RenderViewHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 442303002: DevTools: migrate DevTools APIs to use WebContents instead of RenderViewHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: for landing Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/renderer_overrides_handler_browsertest.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_android.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc

index 5f595ae6484e6085f7db2aa7d8a2cfcde93acedd..c52e8458cd7095ada2ed94cccf4896f79fb3c0fc 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.cc

+++ b/content/browser/renderer_host/render_widget_host_view_android.cc

@@ -1007,10 +1007,10 @@ void RenderWidgetHostViewAndroid::SynchronousFrameMetadata(

ComputeContentsSize(frame_metadata);

// DevTools ScreenCast support for Android WebView.

- if (DevToolsAgentHost::HasFor(RenderViewHost::From(GetRenderWidgetHost()))) {

+ WebContents* web_contents = content_view_core_->GetWebContents();

+ if (DevToolsAgentHost::HasFor(web_contents)) {

scoped_refptr<DevToolsAgentHost> dtah =

- DevToolsAgentHost::GetOrCreateFor(

- RenderViewHost::From(GetRenderWidgetHost()));

+ DevToolsAgentHost::GetOrCreateFor(web_contents);

// Unblock the compositor.

BrowserThread::PostTask(

BrowserThread::UI, FROM_HERE,