chrome/browser/ui/webui/extensions/extension_settings_handler.cc - Issue 442303002: DevTools: migrate DevTools APIs to use WebContents instead of RenderViewHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 442303002: DevTools: migrate DevTools APIs to use WebContents instead of RenderViewHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: for landing Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/extensions/extension_error_ui_util.cc ('k') | content/browser/devtools/devtools_agent_host_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

index 3ac289db6b8d8d0e31627595373b881d66920bf6..fa0360546a375a262f14d546338d54667c5dc7ff 100644

--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

@@ -935,12 +935,12 @@ void ExtensionSettingsHandler::HandleInspectMessage(

RenderViewHost* host = RenderViewHost::FromID(render_process_id,

render_view_id);

- if (!host) {

+ if (!host || !WebContents::FromRenderViewHost(host)) {

// This can happen if the host has gone away since the page was displayed.

return;

}

- DevToolsWindow::OpenDevToolsWindow(host);

+ DevToolsWindow::OpenDevToolsWindow(WebContents::FromRenderViewHost(host));

}

void ExtensionSettingsHandler::HandleLaunchMessage(