chrome/browser/task_manager/task_manager.cc - Issue 442303002: DevTools: migrate DevTools APIs to use WebContents instead of RenderViewHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_manager/task_manager.cc

Issue 442303002: DevTools: migrate DevTools APIs to use WebContents instead of RenderViewHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: for landing Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/task_manager/task_manager.h ('k') | chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_manager/task_manager.cc

diff --git a/chrome/browser/task_manager/task_manager.cc b/chrome/browser/task_manager/task_manager.cc

index ba76c794054503a9fc3a2d77b0f101519890917a..00e58ab61cfb1facae15a46c65bd0237e4ae8e50 100644

--- a/chrome/browser/task_manager/task_manager.cc

+++ b/chrome/browser/task_manager/task_manager.cc

@@ -700,15 +700,6 @@ bool TaskManagerModel::CanActivate(int index) const {

return GetResourceWebContents(index) != NULL;

}

-bool TaskManagerModel::CanInspect(int index) const {

- return GetResource(index)->CanInspect();

-void TaskManagerModel::Inspect(int index) const {

- CHECK_LT(index, ResourceCount());

- GetResource(index)->Inspect();

int TaskManagerModel::GetGoatsTeleported(int index) const {

PerResourceValues& values(GetPerResourceValues(index));

if (!values.is_goats_teleported_valid) {

« no previous file with comments | « chrome/browser/task_manager/task_manager.h ('k') | chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm » ('j') | no next file with comments »