chrome/browser/printing/print_dialog_cloud.cc - Issue 442303002: DevTools: migrate DevTools APIs to use WebContents instead of RenderViewHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_dialog_cloud.cc

Issue 442303002: DevTools: migrate DevTools APIs to use WebContents instead of RenderViewHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: for landing Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/prerender/prerender_browsertest.cc ('k') | chrome/browser/renderer_context_menu/render_view_context_menu.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/print_dialog_cloud.cc

diff --git a/chrome/browser/printing/print_dialog_cloud.cc b/chrome/browser/printing/print_dialog_cloud.cc

index bf08701029c2442137a01ee04de92975b412fbb8..9269c7f7d3af0e690a819cd991e93748eccd1443 100644

--- a/chrome/browser/printing/print_dialog_cloud.cc

+++ b/chrome/browser/printing/print_dialog_cloud.cc

@@ -386,9 +386,9 @@ void CloudPrintFlowHandler::HandleShowDebugger(const base::ListValue* args) {

void CloudPrintFlowHandler::ShowDebugger() {

if (web_ui()) {

- RenderViewHost* rvh = web_ui()->GetWebContents()->GetRenderViewHost();

- if (rvh)

- DevToolsWindow::OpenDevToolsWindow(rvh);

+ WebContents* web_contents = web_ui()->GetWebContents();

+ if (web_contents)

+ DevToolsWindow::OpenDevToolsWindow(web_contents);

}