Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Unified Diff: chrome/browser/extensions/api/app_window/app_window_api.cc

Issue 442303002: DevTools: migrate DevTools APIs to use WebContents instead of RenderViewHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: for landing Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/app_window/app_window_api.cc
diff --git a/chrome/browser/extensions/api/app_window/app_window_api.cc b/chrome/browser/extensions/api/app_window/app_window_api.cc
index fac1edb00e306ea3d971b4287b9b182da4cd5459..51d67b3b95e1a83629d8ad422ed9d584be31dc01 100644
--- a/chrome/browser/extensions/api/app_window/app_window_api.cc
+++ b/chrome/browser/extensions/api/app_window/app_window_api.cc
@@ -68,13 +68,12 @@ namespace {
class DevToolsRestorer : public base::RefCounted<DevToolsRestorer> {
public:
DevToolsRestorer(AppWindowCreateFunction* delayed_create_function,
- content::RenderViewHost* created_view)
+ content::WebContents* web_contents)
: delayed_create_function_(delayed_create_function) {
AddRef(); // Balanced in LoadCompleted.
- DevToolsWindow* devtools_window =
- DevToolsWindow::OpenDevToolsWindow(
- created_view,
- DevToolsToggleAction::ShowConsole());
+ DevToolsWindow* devtools_window = DevToolsWindow::OpenDevToolsWindow(
+ web_contents,
+ DevToolsToggleAction::ShowConsole());
devtools_window->SetLoadCompletedCallback(
base::Bind(&DevToolsRestorer::LoadCompleted, this));
}
@@ -307,7 +306,7 @@ bool AppWindowCreateFunction::RunAsync() {
if (apps::AppWindowRegistry::Get(browser_context())
->HadDevToolsAttached(created_view)) {
- new DevToolsRestorer(this, created_view);
+ new DevToolsRestorer(this, app_window->web_contents());
return true;
}
« no previous file with comments | « chrome/browser/devtools/devtools_window_testing.cc ('k') | chrome/browser/extensions/api/debugger/debugger_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698