Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5470)

Unified Diff: chrome/browser/apps/app_browsertest.cc

Issue 442303002: DevTools: migrate DevTools APIs to use WebContents instead of RenderViewHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: for landing Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/apps/app_browsertest.cc
diff --git a/chrome/browser/apps/app_browsertest.cc b/chrome/browser/apps/app_browsertest.cc
index 44d5e393e69e1464f224159892dc9c286967dd10..45aac38ebd685fdb2a371668cfe22ba7204f28d0 100644
--- a/chrome/browser/apps/app_browsertest.cc
+++ b/chrome/browser/apps/app_browsertest.cc
@@ -823,13 +823,13 @@ void PlatformAppDevToolsBrowserTest::RunTestWithDevTools(
AppWindow* window = GetFirstAppWindow();
ASSERT_TRUE(window);
ASSERT_EQ(window->window_key().empty(), (test_flags & HAS_ID) == 0);
- content::RenderViewHost* rvh = window->web_contents()->GetRenderViewHost();
- ASSERT_TRUE(rvh);
+ content::WebContents* web_contents = window->web_contents();
+ ASSERT_TRUE(web_contents);
// Ensure no DevTools open for the AppWindow, then open one.
- ASSERT_FALSE(DevToolsAgentHost::HasFor(rvh));
- DevToolsWindow::OpenDevToolsWindow(rvh);
- ASSERT_TRUE(DevToolsAgentHost::HasFor(rvh));
+ ASSERT_FALSE(DevToolsAgentHost::HasFor(web_contents));
+ DevToolsWindow::OpenDevToolsWindow(web_contents);
+ ASSERT_TRUE(DevToolsAgentHost::HasFor(web_contents));
if (test_flags & RELAUNCH) {
// Close the AppWindow, and ensure it is gone.
@@ -847,9 +847,9 @@ void PlatformAppDevToolsBrowserTest::RunTestWithDevTools(
ASSERT_TRUE(window);
// DevTools should have reopened with the relaunch.
- rvh = window->web_contents()->GetRenderViewHost();
- ASSERT_TRUE(rvh);
- ASSERT_TRUE(DevToolsAgentHost::HasFor(rvh));
+ web_contents = window->web_contents();
+ ASSERT_TRUE(web_contents);
+ ASSERT_TRUE(DevToolsAgentHost::HasFor(web_contents));
}
}
« no previous file with comments | « chrome/browser/android/dev_tools_server.cc ('k') | chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698