chrome/browser/extensions/api/developer_private/developer_private_api.cc - Issue 442303002: DevTools: migrate DevTools APIs to use WebContents instead of RenderViewHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api.cc

Issue 442303002: DevTools: migrate DevTools APIs to use WebContents instead of RenderViewHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/app_window/app_window_api.cc ('K') | « chrome/browser/extensions/api/debugger/debugger_api.cc ('k') | chrome/browser/extensions/devtools_util.cc » ('j') | content/public/browser/devtools_agent_host.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/developer_private/developer_private_api.cc

diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.cc b/chrome/browser/extensions/api/developer_private/developer_private_api.cc

index dfbd3f1a414ad22c4fd568e18eb4c03a99d7d7d4..615789a26cd2be18020aa85d326fb5bb6e604a27 100644

--- a/chrome/browser/extensions/api/developer_private/developer_private_api.cc

+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.cc

@@ -897,12 +897,13 @@ bool DeveloperPrivateInspectFunction::RunSync() {

content::RenderViewHost* host = content::RenderViewHost::FromID(

render_process_id, render_view_id);

- if (!host) {

+ if (!host || !content::WebContents::FromRenderViewHost(host)) {

// This can happen if the host has gone away since the page was displayed.

return false;

}

- DevToolsWindow::OpenDevToolsWindow(host);

+ DevToolsWindow::OpenDevToolsWindow(

+ content::WebContents::FromRenderViewHost(host));

return true;

}