chrome/browser/ui/views/extensions/extension_popup.cc - Issue 442303002: DevTools: migrate DevTools APIs to use WebContents instead of RenderViewHost.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/extensions/extension_popup.cc

Issue 442303002: DevTools: migrate DevTools APIs to use WebContents instead of RenderViewHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/extensions/api/app_window/app_window_api.cc ('K') | « chrome/browser/ui/panels/panel.cc ('k') | chrome/browser/ui/webui/extensions/extension_error_ui_util.cc » ('j') | content/public/browser/devtools_agent_host.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/views/extensions/extension_popup.h"	5 #include "chrome/browser/ui/views/extensions/extension_popup.h"

6	6

7 #include "base/bind.h"	7 #include "base/bind.h"

8 #include "chrome/browser/chrome_notification_types.h"	8 #include "chrome/browser/chrome_notification_types.h"

9 #include "chrome/browser/devtools/devtools_window.h"	9 #include "chrome/browser/devtools/devtools_window.h"

10 #include "chrome/browser/extensions/extension_view_host.h"	10 #include "chrome/browser/extensions/extension_view_host.h"

(...skipping 207 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
218 return popup;	218 return popup;

219 }	219 }

220	220

221 void ExtensionPopup::ShowBubble() {	221 void ExtensionPopup::ShowBubble() {

222 GetWidget()->Show();	222 GetWidget()->Show();

223	223

224 // Focus on the host contents when the bubble is first shown.	224 // Focus on the host contents when the bubble is first shown.

225 host()->host_contents()->Focus();	225 host()->host_contents()->Focus();

226	226

227 if (inspect_with_devtools_) {	227 if (inspect_with_devtools_) {

228 DevToolsWindow::OpenDevToolsWindow(host()->render_view_host(),	228 DevToolsWindow::OpenDevToolsWindow(host()->host_contents(),

229 DevToolsToggleAction::ShowConsole());	229 DevToolsToggleAction::ShowConsole());

230 }	230 }

231 }	231 }

OLD	NEW