Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 442273002: Cast: Not leak in cast_unittests (Closed)

Created:
6 years, 4 months ago by Alpha Left Google
Modified:
6 years, 4 months ago
Reviewers:
miu
CC:
chromium-reviews, hclam+watch_chromium.org, cbentzel+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Cast: Not leak in cast_unittests cast_unittests was leaking because SimpleTestTickClock was not owned by anyone. This change makes it owned by RtcpReceiverTest. TBR=miu BUG=400728, 393042 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287792

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M media/cast/net/rtcp/rtcp_receiver_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 4 months ago (2014-08-06 10:21:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/442273002/1
6 years, 4 months ago (2014-08-06 10:22:35 UTC) #2
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-06 13:56:16 UTC) #3
commit-bot: I haz the power
Change committed as 287792
6 years, 4 months ago (2014-08-06 17:15:30 UTC) #4
miu
6 years, 4 months ago (2014-08-06 17:35:43 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698