athena: Slide a window offscreen in overview mode to close it.

athena: Slide a window offscreen in overview mode to close it.

BUG=401526
R=mukai@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288335

[Jun Mukai, 2014-08-07 21:00:30]

lgtm with nits

https://codereview.chromium.org/442263004/diff/20001/athena/wm/window_overvie...
File athena/wm/window_overview_mode.cc (right):

https://codereview.chromium.org/442263004/diff/20001/athena/wm/window_overvie...
athena/wm/window_overview_mode.cc:50: : closure_(closure) {}
Can you add DCHECK(!closure.is_null()) here?
Your current usage of this observer satisfies this assertion, and IMO this
observer should not be added at all if closure is null.

https://codereview.chromium.org/442263004/diff/20001/athena/wm/window_overvie...
athena/wm/window_overview_mode.cc:431:
dragged_window_->layer()->SetOpacity(1.f);
should reset dragged_window_ here?

[sadrul, 2014-08-07 21:15:36]

https://codereview.chromium.org/442263004/diff/20001/athena/wm/window_overvie...
File athena/wm/window_overview_mode.cc (right):

https://codereview.chromium.org/442263004/diff/20001/athena/wm/window_overvie...
athena/wm/window_overview_mode.cc:50: : closure_(closure) {}
On 2014/08/07 21:00:30, Jun Mukai wrote:
> Can you add DCHECK(!closure.is_null()) here?
> Your current usage of this observer satisfies this assertion, and IMO this
> observer should not be added at all if closure is null.

Done.

https://codereview.chromium.org/442263004/diff/20001/athena/wm/window_overvie...
athena/wm/window_overview_mode.cc:431:
dragged_window_->layer()->SetOpacity(1.f);
On 2014/08/07 21:00:30, Jun Mukai wrote:
> should reset dragged_window_ here?

Done.

[sadrul, 2014-08-08 12:02:54]

Committed patchset #3 manually as 288335 (presubmit successful).