Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 442253002: Add deoptimization translations. (Closed)

Created:
6 years, 4 months ago by Jarin
Modified:
6 years, 4 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Exclude non-turbofan architectures from the test-run-deopt #

Patch Set 3 : Addressing review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -76 lines) Patch
M src/compiler/ast-graph-builder.h View 3 chunks +3 lines, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 3 chunks +31 lines, -14 lines 0 comments Download
M src/compiler/code-generator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/code-generator.cc View 1 3 chunks +49 lines, -13 lines 0 comments Download
M src/compiler/common-operator.h View 2 chunks +7 lines, -14 lines 0 comments Download
M src/compiler/instruction.h View 3 chunks +28 lines, -3 lines 0 comments Download
M src/compiler/instruction.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/instruction-selector.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 3 chunks +48 lines, -7 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-codegen-deopt.cc View 2 chunks +12 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-run-deopt.cc View 1 2 chunks +19 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-scheduler.cc View 3 chunks +21 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Jarin
Could you have a look? (You already LGTMed this in the Turbofan branch, but I ...
6 years, 4 months ago (2014-08-06 09:28:20 UTC) #1
Benedikt Meurer
https://codereview.chromium.org/442253002/diff/1/src/compiler/instruction-selector.cc File src/compiler/instruction-selector.cc (right): https://codereview.chromium.org/442253002/diff/1/src/compiler/instruction-selector.cc#newcode1003 src/compiler/instruction-selector.cc:1003: descriptor->size(), &inputs.front(), 0, NULL); Nit: use inputs.size() instead of ...
6 years, 4 months ago (2014-08-06 09:41:00 UTC) #2
Jarin
https://codereview.chromium.org/442253002/diff/1/src/compiler/instruction-selector.cc File src/compiler/instruction-selector.cc (right): https://codereview.chromium.org/442253002/diff/1/src/compiler/instruction-selector.cc#newcode1003 src/compiler/instruction-selector.cc:1003: descriptor->size(), &inputs.front(), 0, NULL); On 2014/08/06 09:41:00, Benedikt Meurer ...
6 years, 4 months ago (2014-08-06 10:05:05 UTC) #3
Benedikt Meurer
lgtm
6 years, 4 months ago (2014-08-06 10:47:30 UTC) #4
Michael Starzinger
LGTM.
6 years, 4 months ago (2014-08-06 11:40:42 UTC) #5
Jarin
6 years, 4 months ago (2014-08-06 11:49:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as 22924 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698