|
|
DescriptionChromecast shell build fix for new BrowserContext API:
Triggered by https://codereview.chromium.org/369703002.
R=lcwu@chromium.org
BUG=None
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288227
Patch Set 1 #
Total comments: 1
Patch Set 2 : Remove UrlRequestContextFactory changes. #
Messages
Total messages: 24 (0 generated)
https://codereview.chromium.org/442213002/diff/1/chromecast/shell/browser/url... File chromecast/shell/browser/url_request_context_factory.h (right): https://codereview.chromium.org/442213002/diff/1/chromecast/shell/browser/url... chromecast/shell/browser/url_request_context_factory.h:82: scoped_ptr<net::ChannelIDService> channel_id_service_; There is already an upstream CL to fix this. (https://codereview.chromium.org/430673002/) I just pinged the author to check it in.
On 2014/08/06 18:25:08, lcwu1 wrote: > https://codereview.chromium.org/442213002/diff/1/chromecast/shell/browser/url... > File chromecast/shell/browser/url_request_context_factory.h (right): > > https://codereview.chromium.org/442213002/diff/1/chromecast/shell/browser/url... > chromecast/shell/browser/url_request_context_factory.h:82: > scoped_ptr<net::ChannelIDService> channel_id_service_; > There is already an upstream CL to fix this. > (https://codereview.chromium.org/430673002/) I just pinged the author to check > it in. Only fixing CastBrowserContext now, PTAL.
lgtm
The CQ bit was checked by gunsch@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/442213002/20001
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by lcwu@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/442213002/20001
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by gunsch@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/442213002/20001
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by gunsch@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/442213002/20001
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by gunsch@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/442213002/20001
Message was sent while issue was closed.
Change committed as 288227 |