Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 442213002: Chromecast shell build fix in CastBrowserContext (Closed)

Created:
6 years, 4 months ago by gunsch
Modified:
6 years, 4 months ago
Reviewers:
lcwu1
CC:
chromium-reviews, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Chromecast shell build fix for new BrowserContext API: Triggered by https://codereview.chromium.org/369703002. R=lcwu@chromium.org BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288227

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove UrlRequestContextFactory changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chromecast/shell/browser/cast_browser_context.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/shell/browser/cast_browser_context.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
gunsch
6 years, 4 months ago (2014-08-06 04:48:20 UTC) #1
lcwu1
https://codereview.chromium.org/442213002/diff/1/chromecast/shell/browser/url_request_context_factory.h File chromecast/shell/browser/url_request_context_factory.h (right): https://codereview.chromium.org/442213002/diff/1/chromecast/shell/browser/url_request_context_factory.h#newcode82 chromecast/shell/browser/url_request_context_factory.h:82: scoped_ptr<net::ChannelIDService> channel_id_service_; There is already an upstream CL to ...
6 years, 4 months ago (2014-08-06 18:25:08 UTC) #2
gunsch
On 2014/08/06 18:25:08, lcwu1 wrote: > https://codereview.chromium.org/442213002/diff/1/chromecast/shell/browser/url_request_context_factory.h > File chromecast/shell/browser/url_request_context_factory.h (right): > > https://codereview.chromium.org/442213002/diff/1/chromecast/shell/browser/url_request_context_factory.h#newcode82 > ...
6 years, 4 months ago (2014-08-06 23:02:16 UTC) #3
lcwu1
lgtm
6 years, 4 months ago (2014-08-06 23:04:06 UTC) #4
gunsch
The CQ bit was checked by gunsch@chromium.org
6 years, 4 months ago (2014-08-06 23:13:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/442213002/20001
6 years, 4 months ago (2014-08-06 23:15:26 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-06 23:15:28 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-06 23:15:28 UTC) #8
lcwu1
The CQ bit was checked by lcwu@chromium.org
6 years, 4 months ago (2014-08-07 17:21:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/442213002/20001
6 years, 4 months ago (2014-08-07 17:25:44 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-07 17:25:50 UTC) #11
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-07 17:25:52 UTC) #12
gunsch
The CQ bit was checked by gunsch@chromium.org
6 years, 4 months ago (2014-08-07 19:49:58 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/442213002/20001
6 years, 4 months ago (2014-08-07 19:57:09 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-07 19:57:18 UTC) #15
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-07 19:57:21 UTC) #16
lcwu1
lgtm
6 years, 4 months ago (2014-08-07 20:02:07 UTC) #17
gunsch
The CQ bit was checked by gunsch@chromium.org
6 years, 4 months ago (2014-08-07 20:02:46 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/442213002/20001
6 years, 4 months ago (2014-08-07 20:06:18 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-07 20:06:21 UTC) #20
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-07 20:06:22 UTC) #21
gunsch
The CQ bit was checked by gunsch@chromium.org
6 years, 4 months ago (2014-08-07 23:31:32 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/442213002/20001
6 years, 4 months ago (2014-08-08 00:00:32 UTC) #23
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 06:34:44 UTC) #24
Message was sent while issue was closed.
Change committed as 288227

Powered by Google App Engine
This is Rietveld 408576698