Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 442203002: rebaseline_server live queries: allow comparison against summary files within the Skia repo (Closed)

Created:
6 years, 4 months ago by epoger
Modified:
6 years, 4 months ago
Reviewers:
rmistry
CC:
reviews_skia.org, stephana
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

rebaseline_server live queries: allow comparison against summary files within the Skia repo This is a step towards providing SKP comparisons against expectations, not just other actual results... we still need to allow the user to select JSONKEY_EXPECTEDRESULTS vs JSONKEY_ACTUALRESULTS within the summary files found. BUG=skia:1942 NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/7909f47b423dacaff8623e8be247586108c3be66

Patch Set 1 : meat of the change #

Patch Set 2 : comment-only changes #

Total comments: 3

Patch Set 3 : "repo:", man #

Messages

Total messages: 9 (0 generated)
epoger
Ravi, PTAL at patchset 2. https://codereview.chromium.org/442203002/diff/20001/gm/rebaseline_server/testdata/outputs/expected/compare_rendered_pictures_test.CompareRenderedPicturesTest.test_repo_url/compare_rendered_pictures.json File gm/rebaseline_server/testdata/outputs/expected/compare_rendered_pictures_test.CompareRenderedPicturesTest.test_repo_url/compare_rendered_pictures.json (right): https://codereview.chromium.org/442203002/diff/20001/gm/rebaseline_server/testdata/outputs/expected/compare_rendered_pictures_test.CompareRenderedPicturesTest.test_repo_url/compare_rendered_pictures.json#newcode140 gm/rebaseline_server/testdata/outputs/expected/compare_rendered_pictures_test.CompareRenderedPicturesTest.test_repo_url/compare_rendered_pictures.json:140: "description": "setA" Rietveld shows ...
6 years, 4 months ago (2014-08-06 04:26:28 UTC) #1
rmistry
LGTM https://codereview.chromium.org/442203002/diff/20001/gm/rebaseline_server/compare_rendered_pictures.py File gm/rebaseline_server/compare_rendered_pictures.py (right): https://codereview.chromium.org/442203002/diff/20001/gm/rebaseline_server/compare_rendered_pictures.py#newcode78 gm/rebaseline_server/compare_rendered_pictures.py:78: gs:// URLs, special "repo" URLs, or local filepaths. ...
6 years, 4 months ago (2014-08-06 15:03:53 UTC) #2
epoger
Committing now... https://codereview.chromium.org/442203002/diff/20001/gm/rebaseline_server/compare_rendered_pictures.py File gm/rebaseline_server/compare_rendered_pictures.py (right): https://codereview.chromium.org/442203002/diff/20001/gm/rebaseline_server/compare_rendered_pictures.py#newcode78 gm/rebaseline_server/compare_rendered_pictures.py:78: gs:// URLs, special "repo" URLs, or local ...
6 years, 4 months ago (2014-08-06 15:08:19 UTC) #3
epoger
The CQ bit was checked by epoger@google.com
6 years, 4 months ago (2014-08-06 15:08:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/442203002/40001
6 years, 4 months ago (2014-08-06 15:08:38 UTC) #5
epoger
The CQ bit was unchecked by epoger@google.com
6 years, 4 months ago (2014-08-06 15:37:34 UTC) #6
epoger
The CQ bit was checked by epoger@google.com
6 years, 4 months ago (2014-08-06 15:37:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/442203002/40001
6 years, 4 months ago (2014-08-06 15:37:48 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 15:37:58 UTC) #9
Message was sent while issue was closed. 
Change committed as 7909f47b423dacaff8623e8be247586108c3be66

Powered by Google App Engine
This is Rietveld 408576698