Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: chrome/browser/drive/drive_api_util.cc

Issue 442193002: Parse Drive API responses all at once in the blocking pool. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + really drop GetDataRequest Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/drive/drive_api_util.cc
diff --git a/chrome/browser/drive/drive_api_util.cc b/chrome/browser/drive/drive_api_util.cc
index 1c0d2bec9260e37391ad659e60b84671fd1553e4..9359c3783b6cdbb811c213a6be79b845a983f155 100644
--- a/chrome/browser/drive/drive_api_util.cc
+++ b/chrome/browser/drive/drive_api_util.cc
@@ -139,29 +139,6 @@ std::string CanonicalizeResourceId(const std::string& resource_id) {
const char kDocsListScope[] = "https://docs.google.com/feeds/";
const char kDriveAppsScope[] = "https://www.googleapis.com/auth/drive.apps";
-void ParseShareUrlAndRun(const google_apis::GetShareUrlCallback& callback,
- google_apis::GDataErrorCode error,
- scoped_ptr<base::Value> value) {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
-
- if (!value) {
- callback.Run(error, GURL());
- return;
- }
-
- // Parsing ResourceEntry is cheap enough to do on UI thread.
- scoped_ptr<google_apis::ResourceEntry> entry =
- google_apis::ResourceEntry::ExtractAndParse(*value);
- if (!entry) {
- callback.Run(google_apis::GDATA_PARSE_ERROR, GURL());
- return;
- }
-
- const google_apis::Link* share_link =
- entry->GetLinkByType(google_apis::Link::LINK_SHARE);
- callback.Run(error, share_link ? share_link->href() : GURL());
-}
-
scoped_ptr<google_apis::ResourceEntry>
ConvertFileResourceToResourceEntry(
const google_apis::FileResource& file_resource) {

Powered by Google App Engine
This is Rietveld 408576698