Source/modules/serviceworkers/RespondWithObserver.cpp - Issue 442183003: FetchEvent should not forcibly reject an unresolved Promise when destructed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/RespondWithObserver.cpp

Issue 442183003: FetchEvent should not forcibly reject an unresolved Promise when destructed (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/serviceworker/fetch-event.html ('K') | « LayoutTests/http/tests/serviceworker/resources/fetch-event-test-worker.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/RespondWithObserver.cpp

diff --git a/Source/modules/serviceworkers/RespondWithObserver.cpp b/Source/modules/serviceworkers/RespondWithObserver.cpp

index af2995de13a8595e250337ac1b2e308b7d05c1f4..a06100e18135959e5b0b3a5ca7b73957c89b2cda 100644

--- a/Source/modules/serviceworkers/RespondWithObserver.cpp

+++ b/Source/modules/serviceworkers/RespondWithObserver.cpp

@@ -62,8 +62,7 @@ PassRefPtr<RespondWithObserver> RespondWithObserver::create(ExecutionContext* co

RespondWithObserver::~RespondWithObserver()

{

- if (m_state == Pending)

- sendResponse(nullptr);

+ ASSERT(m_state != Pending);

}

void RespondWithObserver::contextDestroyed()

« LayoutTests/http/tests/serviceworker/fetch-event.html ('K') | « LayoutTests/http/tests/serviceworker/resources/fetch-event-test-worker.js ('k') | no next file » | no next file with comments »