Typecheck chrome://downloads using CompilerPass.java

chrome/browser/resources/downloads/downloads.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(jhawkins): Use hidden instead of showInline* and display:none.
 
 /**
+ * The type of the download object. The definition is based on
+ * chrome/browser/ui/webui/downloads_dom_handler.cc:CreateDownloadItemValue()
+ * @typedef {{by_ext_id: (string|undefined),
+ *            by_ext_name: (string|undefined),
+ *            danger_type: (string|undefined),
+ *            date_string: string,
+ *            file_externally_removed: boolean,
+ *            file_name: string,
+ *            file_path: string,
+ *            file_url: string,
+ *            id: string,
+ *            last_reason_text: (string|undefined),
+ *            otr: boolean,
+ *            percent: (number|undefined),
+ *            progress_status_text: (string|undefined),
+ *            received: (number|undefined),
+ *            resume: boolean,
+ *            retry: boolean,
+ *            since_string: string,
+ *            started: number,
+ *            state: string,
+ *            total: number,
+ *            url: string}}
+ */
+var BackendDownloadObject;
+
+/**
  * Sets the display style of a node.
  * @param {!Element} node The target element to show or hide.
  * @param {boolean} isShow Should the target element be visible.
  */
 function showInline(node, isShow) {
   node.style.display = isShow ? 'inline' : 'none';
 }
 
 /**
  * Sets the display style of a node.
  * @param {!Element} node The target element to show or hide.
  * @param {boolean} isShow Should the target element be visible.
  */
 function showInlineBlock(node, isShow) {
   node.style.display = isShow ? 'inline-block' : 'none';
 }
 
 /**
  * Creates a link with a specified onclick handler and content.
  * @param {function()} onclick The onclick handler.
  * @param {string} value The link text.
- * @return {Element} The created link element.
+ * @return {!Element} The created link element.
  */
 function createLink(onclick, value) {
   var link = document.createElement('a');
   link.onclick = onclick;
   link.href = '#';
   link.textContent = value;
   link.oncontextmenu = function() { return false; };
   return link;
 }
 
@@ skipping 11 matching lines @@
   return button;
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // Downloads
 /**
  * Class to hold all the information about the visible downloads.
  * @constructor
  */
 function Downloads() {
+  /**
+   * @type {!Object.<string, Download>}
+   * @private
+   */
   this.downloads_ = {};
   this.node_ = $('downloads-display');
   this.summary_ = $('downloads-summary-text');
   this.searchText_ = '';
 
   // Keep track of the dates of the newest and oldest downloads so that we
   // know where to insert them.
   this.newestTime_ = -1;
 
   // Icon load request queue.
   this.iconLoadQueue_ = [];
   this.isIconLoading_ = false;
 }
 
 /**
  * Called when a download has been updated or added.
- * @param {Object} download A backend download object (see downloads_ui.cc)
+ * @param {BackendDownloadObject} download A backend download object
  */
 Downloads.prototype.updated = function(download) {
   var id = download.id;
   if (!!this.downloads_[id]) {
     this.downloads_[id].update(download);
   } else {
     this.downloads_[id] = new Download(download);
     // We get downloads in display order, so we don't have to worry about
     // maintaining correct order - we can assume that any downloads not in
     // display order are new ones and so we can add them to the top of the
@@ skipping 34 matching lines @@
 
   var hasDownloads = false;
   for (var i in this.downloads_) {
     hasDownloads = true;
     break;
   }
 };
 
 /**
  * Returns the number of downloads in the model. Used by tests.
- * @return {integer} Returns the number of downloads shown on the page.
+ * @return {number} Returns the number of downloads shown on the page.
  */
 Downloads.prototype.size = function() {
   return Object.keys(this.downloads_).length;
 };
 
 /**
  * Update the date visibility in our nodes so that no date is
  * repeated.
  * @private
  */
 Downloads.prototype.updateDateDisplay_ = function() {
   var dateContainers = document.getElementsByClassName('date-container');
   var displayed = {};
   for (var i = 0, container; container = dateContainers[i]; i++) {
     var dateString = container.getElementsByClassName('date')[0].innerHTML;
     if (!!displayed[dateString]) {
       container.style.display = 'none';
     } else {
       displayed[dateString] = true;
       container.style.display = 'block';
     }
   }
 };
 
 /**
  * Remove a download.
- * @param {number} id The id of the download to remove.
+ * @param {string} id The id of the download to remove.
  */
 Downloads.prototype.remove = function(id) {
   this.node_.removeChild(this.downloads_[id].node);
   delete this.downloads_[id];
   this.updateDateDisplay_();
 };
 
 /**
  * Clear all downloads and reset us back to a null state.
  */
@@ skipping 56 matching lines @@
     if (!this.downloads_[downloads[i].id])
       return true;
   }
   return false;
 };
 
 ///////////////////////////////////////////////////////////////////////////////
 // Download
 /**
  * A download and the DOM representation for that download.
- * @param {Object} download A backend download object (see downloads_ui.cc)
+ * @param {BackendDownloadObject} download A backend download object
  * @constructor
  */
 function Download(download) {
   // Create DOM
   this.node = createElementWithClassName(
       'div', 'download' + (download.otr ? ' otr' : ''));
 
   // Dates
   this.dateContainer_ = createElementWithClassName('div', 'date-container');
   this.node.appendChild(this.dateContainer_);
@@ skipping 133 matching lines @@
       loadTimeData.getString('danger_discard'));
   this.danger_.appendChild(this.dangerDiscard_);
 
   // Update member vars.
   this.update(download);
 }
 
 /**
  * The states a download can be in. These correspond to states defined in
  * DownloadsDOMHandler::CreateDownloadItemValue
+ * @enum {string}
  */
 Download.States = {
   IN_PROGRESS: 'IN_PROGRESS',
   CANCELLED: 'CANCELLED',
   COMPLETE: 'COMPLETE',
   PAUSED: 'PAUSED',
   DANGEROUS: 'DANGEROUS',
   INTERRUPTED: 'INTERRUPTED',
 };
 
 /**
  * Explains why a download is in DANGEROUS state.
+ * @enum {string}
  */
 Download.DangerType = {
   NOT_DANGEROUS: 'NOT_DANGEROUS',
   DANGEROUS_FILE: 'DANGEROUS_FILE',
   DANGEROUS_URL: 'DANGEROUS_URL',
   DANGEROUS_CONTENT: 'DANGEROUS_CONTENT',
   UNCOMMON_CONTENT: 'UNCOMMON_CONTENT',
   DANGEROUS_HOST: 'DANGEROUS_HOST',
   POTENTIALLY_UNWANTED: 'POTENTIALLY_UNWANTED',
 };
 
 /**
  * @param {number} a Some float.
  * @param {number} b Some float.
- * @param {number} opt_pct Percent of min(a,b).
+ * @param {number=} opt_pct Percent of min(a,b).
  * @return {boolean} true if a is within opt_pct percent of b.
  */
 function floatEq(a, b, opt_pct) {
   return Math.abs(a - b) < (Math.min(a, b) * (opt_pct || 1.0) / 100.0);
 }
 
 /**
  * Constants and "constants" for the progress meter.
  */
 Download.Progress = {
@@ skipping 15 matching lines @@
   Download.Progress.height = Download.Progress.SIDE * Download.Progress.scale;
   Download.Progress.radius = Download.Progress.HALF * Download.Progress.scale;
   Download.Progress.centerX = Download.Progress.HALF * Download.Progress.scale;
   Download.Progress.centerY = Download.Progress.HALF * Download.Progress.scale;
 }
 computeDownloadProgress();
 
 // Listens for when device-pixel-ratio changes between any zoom level.
 [0.3, 0.4, 0.6, 0.7, 0.8, 0.95, 1.05, 1.2, 1.4, 1.6, 1.9, 2.2, 2.7, 3.5, 4.5
 ].forEach(function(scale) {
-  matchMedia('(-webkit-min-device-pixel-ratio:' + scale + ')').addListener(
+  window.matchMedia('(-webkit-min-device-pixel-ratio:' + scale + ')')
+      .addListener(

[Dan Beam, 2014/08/05 23:14:33]

var media = '(-webkit-min-device-pixel-ratio:' + scale + ')';
window.matchMedia(media).addListener(computeDownloadProgress);

[Vitaly Pavlenko, 2014/08/06 00:28:53]

Done.

     function() {
       computeDownloadProgress();
   });
 });
 
 var ImageCache = {};
 function getCachedImage(src) {
   if (!ImageCache[src]) {
     ImageCache[src] = new Image();
     ImageCache[src].src = src;
   }
   return ImageCache[src];
 }
 
 /**
  * Updates the download to reflect new data.
- * @param {Object} download A backend download object (see downloads_ui.cc)
+ * @param {BackendDownloadObject} download A backend download object
  */
 Download.prototype.update = function(download) {
   this.id_ = download.id;
   this.filePath_ = download.file_path;
   this.fileUrl_ = download.file_url;
   this.fileName_ = download.file_name;
   this.url_ = download.url;
   this.state_ = download.state;
   this.fileExternallyRemoved_ = download.file_externally_removed;
   this.dangerType_ = download.danger_type;
@@ skipping 227 matching lines @@
     case Download.States.DANGEROUS:
       // danger_url_desc is also used by DANGEROUS_CONTENT.
       var desc = this.dangerType_ == Download.DangerType.DANGEROUS_FILE ?
           'danger_file_desc' : 'danger_url_desc';
       return loadTimeData.getString(desc);
     case Download.States.INTERRUPTED:
       return this.lastReasonDescription_;
     case Download.States.COMPLETE:
       return this.fileExternallyRemoved_ ?
           loadTimeData.getString('status_removed') : '';
+    default:
+      assertNotReached();
+      return '';
   }

[Dan Beam, 2014/08/05 23:14:33]

nit:

  assertNotReached();
  return '';

after the switch() {} instead of as the default:

[Vitaly Pavlenko, 2014/08/06 00:29:25]

Done.

 };
 
 /**
  * Tells the backend to initiate a drag, allowing users to drag
  * files from the download page and have them appear as native file
  * drags.
  * @return {boolean} Returns false to prevent the default action.
  * @private
  */
 Download.prototype.drag_ = function() {
@@ skipping 131 matching lines @@
   openDownloadsFolderLink.oncontextmenu = function() { return false; };
 
   $('search-link').onclick = function(e) {
     setSearch('');
     e.preventDefault();
     $('term').value = '';
     return false;
   };
 
   $('term').onsearch = function(e) {
-    setSearch(this.value);
+    setSearch($('term').value);
   };
 }
 
 function setSearch(searchText) {
   fifoResults.length = 0;
   downloads.setSearchText(searchText);
   searchText = searchText.toString().match(/(?:[^\s"]+|"[^"]*")+/g);
   if (searchText) {
     searchText = searchText.map(function(term) {
       // strip quotes
@@ skipping 62 matching lines @@
     if (Date.now() - start > 50) {
       clearTimeout(resultsTimeout);
       resultsTimeout = setTimeout(tryDownloadUpdatedPeriodically, 5);
       break;
     }
   }
 }
 
 // Add handlers to HTML elements.
 window.addEventListener('DOMContentLoaded', load);