chrome/browser/extensions/extension_gcm_app_handler.cc - Issue 442123003: [GCM] Adding the OnSendAcknowledgement event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_gcm_app_handler.cc

Issue 442123003: [GCM] Adding the OnSendAcknowledgement event (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing code review comments. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_gcm_app_handler.cc

diff --git a/chrome/browser/extensions/extension_gcm_app_handler.cc b/chrome/browser/extensions/extension_gcm_app_handler.cc

index c294dfc83d033e6620d1dec2aaaa745311474643..71467b564bf7d8c2fa0ff45719e4b4ae7b9498fd 100644

--- a/chrome/browser/extensions/extension_gcm_app_handler.cc

+++ b/chrome/browser/extensions/extension_gcm_app_handler.cc

@@ -92,6 +92,12 @@ void ExtensionGCMAppHandler::OnSendError(

#endif

}

+void ExtensionGCMAppHandler::OnSendAcknowledged(

+ const std::string& app_id,

+ const std::string& message_id) {

+ // This event is not exposed to JS API. It terminates here.

void ExtensionGCMAppHandler::OnExtensionLoaded(

content::BrowserContext* browser_context,

const Extension* extension) {