Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2428)

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_service_client.h

Issue 442073003: Separate CryptoVerifyImpl into its own file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Feedback Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/networking_private/networking_private_service_client.h
diff --git a/chrome/browser/extensions/api/networking_private/networking_private_service_client.h b/chrome/browser/extensions/api/networking_private/networking_private_service_client.h
index beb55eaaf0c6dcae62dfb2007f0667a35c1bd8bb..63708c5bd55f5125c5f29284ba3d580648b6f5b2 100644
--- a/chrome/browser/extensions/api/networking_private/networking_private_service_client.h
+++ b/chrome/browser/extensions/api/networking_private/networking_private_service_client.h
@@ -64,9 +64,11 @@ class NetworkingPrivateServiceClient
std::string public_key;
};
- CryptoVerify() {}
- virtual ~CryptoVerify() {}
+ CryptoVerify();
+ virtual ~CryptoVerify();
+ // Must be provided by the implementation. May return NULL if certificate
+ // verification is unavailable, see NetworkingPrivateServiceClient().
static CryptoVerify* Create();
virtual void VerifyDestination(const Credentials& credentials,
@@ -104,7 +106,8 @@ class NetworkingPrivateServiceClient
// Takes ownership of |wifi_service| and |crypto_verify|. They are accessed
// and deleted on the worker thread. The deletion task is posted during the
- // NetworkingPrivateServiceClient shutdown.
+ // NetworkingPrivateServiceClient shutdown. |crypto_verify| may be NULL in
+ // which case Verify* will return a 'not implemented' error.
mef 2014/08/07 22:57:39 nit: It returns kErrorNotSupported.
NetworkingPrivateServiceClient(wifi::WiFiService* wifi_service,
CryptoVerify* crypto_verify);
@@ -254,6 +257,7 @@ class NetworkingPrivateServiceClient
// Observers to Network Events.
ObserverList<Observer> network_events_observers_;
// Interface for Verify* methods. Used and deleted on the worker thread.
+ // May be NULL.
scoped_ptr<CryptoVerify> crypto_verify_;
// Interface to WiFiService. Used and deleted on the worker thread.
scoped_ptr<wifi::WiFiService> wifi_service_;

Powered by Google App Engine
This is Rietveld 408576698