Separate CryptoVerifyImpl into its own file.

chrome/browser/extensions/api/networking_private/networking_private_service_client.h

Index: chrome/browser/extensions/api/networking_private/networking_private_service_client.h
diff --git a/chrome/browser/extensions/api/networking_private/networking_private_service_client.h b/chrome/browser/extensions/api/networking_private/networking_private_service_client.h
index beb55eaaf0c6dcae62dfb2007f0667a35c1bd8bb..bf561ae0f2bd0c1538d7ae5e300aaa27779f947b 100644
--- a/chrome/browser/extensions/api/networking_private/networking_private_service_client.h
+++ b/chrome/browser/extensions/api/networking_private/networking_private_service_client.h
@@ -64,9 +64,11 @@ class NetworkingPrivateServiceClient
       std::string public_key;
     };
 
-    CryptoVerify() {}
-    virtual ~CryptoVerify() {}
+    CryptoVerify();
+    virtual ~CryptoVerify();
 
+    // Must be provided by the implementation. May return NULL if certificate
+    // verification is unavailable, in which case those functions will fail.

[pneubeck (no reviews), 2014/08/06 16:01:38]

Sorry, I don't understand the second half of the second sentence.

If this returns NULL, which functions will fail? Do you mean
NetworkingPrivateServiceClient::Verify* ?
Should this comment be at the c'tor of NetworkingPrivateServiceClient, when it
gets a NULL ptr for |crypto_verify|?

[stevenjb, 2014/08/06 16:52:14]

Yes, will clarify and add a similar comment to the constructor.

     static CryptoVerify* Create();
 
     virtual void VerifyDestination(const Credentials& credentials,
@@ -254,6 +256,7 @@ class NetworkingPrivateServiceClient
   // Observers to Network Events.
   ObserverList<Observer> network_events_observers_;
   // Interface for Verify* methods. Used and deleted on the worker thread.
+  // May be NULL.
   scoped_ptr<CryptoVerify> crypto_verify_;
   // Interface to WiFiService. Used and deleted on the worker thread.
   scoped_ptr<wifi::WiFiService> wifi_service_;